geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "B.J. Reed (JIRA)" <j...@apache.org>
Subject [jira] Commented: (GERONIMODEVTOOLS-325) "Download and Install" button should be disabled/enabled appropriately
Date Mon, 04 Aug 2008 14:22:44 GMT

    [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619526#action_12619526
] 

B.J. Reed commented on GERONIMODEVTOOLS-325:
--------------------------------------------

This is an improvement.  I had a problem installing the patch, specifically, there is a snippet
of code that was changed from 

ConfirmInstallDialog dialog = new ConfirmInstallDialog(shell, getRuntimeName(), installDir.getText(),
license);

to 

ConfirmInstallDialog dialog = new ConfirmInstallDialog(shell, getRuntimeName(), installDir,
license);

This line did not compile.  Changing it back made it compile.

After making that change, the processing seems a little better, but it would be nice to have
the "download and install" button visually grayed out so that the user knew by looking at
it that it is not enabled. Also what happens now if I want to download to a new directory
doesn't really seem very good.  Clarifying my steps and what I see

I want to download into a new direcotry of c:\f

1. type in C:\f\geronimo-tomcat6-javaee5-2.1.1 in the entry field and click "download and
install" since it looks enabled (nothing happens).
2. Click "Browse" and create the necessary folders
3. Now clicking "download and install" brings up the same dialog I just had when I clicked
on the browse button.  (why is this dialog here?  I already have the correct text in the entry
field for where I want to download to)  Then it proceeds to the license and downloading.

> "Download and Install" button should be disabled/enabled appropriately
> ----------------------------------------------------------------------
>
>                 Key: GERONIMODEVTOOLS-325
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-325
>             Project: Geronimo-Devtools
>          Issue Type: Bug
>          Components: eclipse-plugin
>    Affects Versions: 2.1.2
>            Reporter: B.J. Reed
>            Assignee: B.J. Reed
>            Priority: Trivial
>             Fix For: 2.1.2
>
>         Attachments: GERONIMODEVTOOLS-325.patch, GERONIMODEVTOOLS-325_updated.patch,
GERONIMODEVTOOLS-325_updated_latest.patch
>
>
> After selecting which server I want to use, the "Application Server Installation Directory"
field is blank and the "Download and Install" button is enabled.  Hitting this button does
nothing -1) it should be disabled on the page when the page is first shown.
> If I enter a directory that does not exist, a message shows at the top of the dialog
saying "The specified directory does not exist".  2) the button should be disabled when that
message appears and enabled when one of the "download allowable" messages appears (there seem
to be several).
> 3) Also, in stead of disabling for 2), it would be slightly more usable to allow the
user to click the "Download and Install" button and then ask the user if they wanted to create
that directory.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message