geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Kirby (JIRA)" <>
Subject [jira] Commented: (GERONIMODEVTOOLS-171) Remove hard-coded Geronimo name from launch console message and tool-tip
Date Mon, 25 Aug 2008 17:45:44 GMT


Ted Kirby commented on GERONIMODEVTOOLS-171:

This patch was actually applied with GERONIMODEVTOOLS-341.  Sachin's comment remains valid.

> Remove hard-coded Geronimo name from launch console message and tool-tip
> ------------------------------------------------------------------------
>                 Key: GERONIMODEVTOOLS-171
>                 URL:
>             Project: Geronimo-Devtools
>          Issue Type: Improvement
>          Components: eclipse-plugin
>    Affects Versions: 2.0.x
>            Reporter: Ted Kirby
>            Assignee: Tim McConnell
>             Fix For: 2.1.3
>         Attachments: GD-171.patch
> Replace:
> console=Geronimo Console
> consoleTooltip=Apache Geronimo Console
> with:
> console={0} Console
> consoleTooltip={0} Console
> in eclipse-plugin\plugins\\src\org\apache\geronimo\st\ui\internal\,
and allow the server name to be determined by server.getName().
> This allows for an extensible approach, for servers based on Geronimo.  No change is
required to support other servers.
> In this particular case, plugins\\src\org\apache\geronimo\st\ui\actions\LaunchGeronimoConsoleAction.G_SERVER_PREFIX
 is hard-coded to "org.apache.geronimo".  It would be nice if this could be paramterized in
some fashion to avoid having to replace the class in its entirety, just to change this value
to determine if the "Launch {ServerName} Console" menu item should be activated.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message