Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 83171 invoked from network); 15 Jul 2008 15:02:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 15 Jul 2008 15:02:38 -0000 Received: (qmail 21838 invoked by uid 500); 15 Jul 2008 15:02:36 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 21775 invoked by uid 500); 15 Jul 2008 15:02:36 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 21764 invoked by uid 99); 15 Jul 2008 15:02:36 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Jul 2008 08:02:36 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [209.86.89.64] (HELO elasmtp-curtail.atl.sa.earthlink.net) (209.86.89.64) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Jul 2008 15:01:42 +0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=dk20050327; d=earthlink.net; b=q9NLLoobgp70MY7GM9vFt4utFRygqBGkfP2XoVlyEkGP4KGqKZtRj1JgiNGXeHxo; h=Received:Message-ID:Date:From:User-Agent:MIME-Version:To:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-ELNK-Trace:X-Originating-IP; Received: from [24.40.200.241] (helo=tetra.local) by elasmtp-curtail.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1KIm2X-0007x7-9q for dev@geronimo.apache.org; Tue, 15 Jul 2008 11:02:05 -0400 Message-ID: <487CBBEC.3080701@earthlink.net> Date: Tue, 15 Jul 2008 11:02:04 -0400 From: Joe Bohn User-Agent: Thunderbird 2.0.0.14 (Macintosh/20080421) MIME-Version: 1.0 To: dev@geronimo.apache.org Subject: Re: recent console changes in trunk References: <72167.7114.qm@web57506.mail.re1.yahoo.com> <487CA561.6080707@earthlink.net> <9dc4201d0807150733l4038dd84gebc53a54e602e5f2@mail.gmail.com> <487CBA72.3040305@earthlink.net> In-Reply-To: <487CBA72.3040305@earthlink.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ELNK-Trace: c408501814fc19611aa676d7e74259b7b3291a7d08dfec79308948122273bd6997e08970f8656bac350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-Originating-IP: 24.40.200.241 X-Virus-Checked: Checked by ClamAV on apache.org Joe Bohn wrote: > Shrey Banga wrote: >> I don't think that can be done because pluto.css is loaded after >> main.css and it'll override any previous css styles for label. > > > I'm not sure about what the correct processing is supposed to be for the > style sheets ... but I made the change locally to add in a label entry > in main.css without the float:left and it resolved the problem for me. I > can go ahead and check this in if you'd like. In general I don't like > duplication but I like have most if not all of the settings we care > about in one place. Oops ... I just realized that I made the changes in branches/2.1 (which I'm not even sure ever exhibited the problem). So my test may be invalid. Also, it may not be that hot of an issue for 2.1.2 ... for some reason I forgot that the issues were were seeing were in trunk. :-) I'm checking the change out on trunk now ... will let you know the results soon. Joe > > Joe > > >> >> On Tue, Jul 15, 2008 at 6:55 PM, Joe Bohn > > wrote: >> >> YunFeng Ma wrote: >> >> I tested the console in FireFox 2.x and IE 6.x after removing >> label tag in pluto.css and didn't see any problem. I prefer to >> remove it before G v2.1.2 is out of the door. >> >> >> I agree we want this fixed before we ship 2.1.2. >> However, I'm not sure modifying pluto.css is the best way to go. >> All of our style sheet changes for the console have typically been >> restricted to main.css. I think pluto.css is pretty much a direct >> copy from pluto. It might be easier to maintain if we continue to >> keep our changes limited to main.css. Can you try fixing this by >> adding a new label entry in main.css without float:left? >> >> Joe >> >> >> >> >> -- Yun Feng >> >> Shrey Banga wrote: >> > I've opened a JIRA (GERONIMO-4204) for this issue. I need to >> know if the >> > float:left for labels in pluto.css is needed and where >> because it >> > affects all Admin Console portlets. >> > >> > On Mon, Jul 14, 2008 at 3:09 PM, Shrey Banga >> >> > > >> wrote: >> > >> > After rebuilding the server I too faced the same problem >> and on >> > further inspection I could make out the problem was >> because the >> > patch GERONIMO-4081 Accessibility issues (at revision: >> 675083) has >> > surrounded text by