Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 6973 invoked from network); 28 Jul 2008 09:54:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 28 Jul 2008 09:54:24 -0000 Received: (qmail 58975 invoked by uid 500); 28 Jul 2008 09:54:23 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 58467 invoked by uid 500); 28 Jul 2008 09:54:22 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 58456 invoked by uid 99); 28 Jul 2008 09:54:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Jul 2008 02:54:21 -0700 X-ASF-Spam-Status: No, hits=-1999.6 required=10.0 tests=ALL_TRUSTED,SUBJECT_FUZZY_TION X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Jul 2008 09:53:35 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id D7CF0234C173 for ; Mon, 28 Jul 2008 02:53:31 -0700 (PDT) Message-ID: <1927312980.1217238811868.JavaMail.jira@brutus> Date: Mon, 28 Jul 2008 02:53:31 -0700 (PDT) From: "Ashish Jain (JIRA)" To: dev@geronimo.apache.org Subject: [jira] Commented: (GERONIMODEVTOOLS-325) "Download and Install" button should be disabled/enabled appropriately In-Reply-To: <1758784668.1207756404304.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617394#action_12617394 ] Ashish Jain commented on GERONIMODEVTOOLS-325: ---------------------------------------------- Found some problems with the patch, uploading a new patch > "Download and Install" button should be disabled/enabled appropriately > ---------------------------------------------------------------------- > > Key: GERONIMODEVTOOLS-325 > URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-325 > Project: Geronimo-Devtools > Issue Type: Bug > Components: eclipse-plugin > Affects Versions: 2.1.2 > Reporter: B.J. Reed > Assignee: Ashish Jain > Priority: Trivial > Fix For: 2.1.2 > > Attachments: GERONIMODEVTOOLS-325.patch, GERONIMODEVTOOLS-325_updated.patch > > > After selecting which server I want to use, the "Application Server Installation Directory" field is blank and the "Download and Install" button is enabled. Hitting this button does nothing -1) it should be disabled on the page when the page is first shown. > If I enter a directory that does not exist, a message shows at the top of the dialog saying "The specified directory does not exist". 2) the button should be disabled when that message appears and enabled when one of the "download allowable" messages appears (there seem to be several). > 3) Also, in stead of disabling for 2), it would be slightly more usable to allow the user to click the "Download and Install" button and then ask the user if they wanted to create that directory. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.