geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Donald Woods <dwo...@apache.org>
Subject Re: Restart of configurations not picking up any changes made
Date Thu, 24 Jul 2008 18:38:41 GMT
Sounds like a JIRA and patch is needed.....


-Donald


Manu George wrote:
> So to get the changes reflected on restart we need to call
> attributeStore.applyOverrides in
> ConfigurationUtil.startConfigurationGbeans method. Let me know if this
> is an issue and I will open a JIRA and attach a patch
> 
> Regards
> Manu
> 
> On Thu, Jul 24, 2008 at 4:56 PM, Manu George <manu.t.george@gmail.com> wrote:
>> Please disregard the part about the Configuration class. On further
>> analysis I found that the restart results in
>> KernelConfigurationManager.start
>>
>> Regards
>> Manu
>>
>> On Thu, Jul 24, 2008 at 4:42 PM, Manu George <manu.t.george@gmail.com> wrote:
>>> Hi,
>>>       I just found a behaviour in geronimo that I am not certain is
>>> there by design. If I edit one of the gbean attributes of an already
>>> started gbean in a configuration and I then restart that configuration
>>> from the console then the edited properties are not reflected in the
>>> restarted gbean. On editing the properties are definitely persisted to
>>> config.xml but then on restart they are not read. On seeing the
>>> Configuration class I found this code in the constructor
>>>
>>>        //
>>>            // Deserialize the GBeans in the configurationData
>>>            //
>>>            Collection<GBeanData> gbeans =
>>> configurationData.getGBeans(configurationClassLoader);
>>>            if (attributeStore != null) {
>>>                gbeans = attributeStore.applyOverrides(id, gbeans,
>>> configurationClassLoader);
>>>            }
>>>            for (GBeanData gbeanData : gbeans) {
>>>                this.gbeans.put(gbeanData.getAbstractName(), gbeanData);
>>>            }
>>>
>>>
>>> In the doStart method there is only a debug statement saying that the
>>> configuration has started. Shouldn't there be something in the doStart
>>> method to apply overrides? Or am I missing something.
>>>
>>> Regards
>>> Manu
>>>
> 

Mime
View raw message