Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 14826 invoked from network); 12 Jun 2008 13:30:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 12 Jun 2008 13:30:41 -0000 Received: (qmail 20008 invoked by uid 500); 12 Jun 2008 13:30:42 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 19959 invoked by uid 500); 12 Jun 2008 13:30:42 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 19948 invoked by uid 99); 12 Jun 2008 13:30:42 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Jun 2008 06:30:42 -0700 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jason.dillon@gmail.com designates 209.85.142.187 as permitted sender) Received: from [209.85.142.187] (HELO ti-out-0910.google.com) (209.85.142.187) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Jun 2008 13:29:50 +0000 Received: by ti-out-0910.google.com with SMTP id b6so1190018tic.1 for ; Thu, 12 Jun 2008 06:30:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:from:to :in-reply-to:content-type:mime-version:subject:date:references :x-mailer:sender; bh=bO135CodNL2/lnkn/QXCOlys86LMwdrWpGfZU9A6DTE=; b=WKnXsdj7TJ0zv4Iuba7B4T1AySw5fm57S9DSPdeARHiVa0ZtJcQiXb8N//7VzeVT3c 5+WWokuCBMknCZ4mMPyB72TSjrURV5zb4FRngQK6ECHR/XtTelY/F0iRRs/1lXlQkW6e X1FkN2CyaQnRjN6tU2ecYA0rPy4n1551EEOUM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:from:to:in-reply-to:content-type:mime-version:subject :date:references:x-mailer:sender; b=fkLKVP23dzsoxjYZkIawE6ghZvspNUCQPQXhotD+SuLToLS9y5lKKyuW9ypz8qsb1F Zz2cMz0Bcw7E0Lo1Uq26wRLU28mzo9vUp1a+HUWhK09Z9pZ5reODHVhd+ySEaKLgF071 1sqg6b4BjIQgLWJk+PLmcv9j0HLQiMYR2sokA= Received: by 10.110.2.2 with SMTP id 2mr720909tib.56.1213277407125; Thu, 12 Jun 2008 06:30:07 -0700 (PDT) Received: from ?10.0.1.97? ( [58.8.1.125]) by mx.google.com with ESMTPS id y3sm1465984tia.3.2008.06.12.06.30.04 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 12 Jun 2008 06:30:05 -0700 (PDT) Message-Id: <0A5FE0CD-50F3-46DB-8F53-0FD7AC1E0F35@planet57.com> From: Jason Dillon To: dev@geronimo.apache.org In-Reply-To: <9BF37F50-2008-4665-930B-EE9E39C90F1B@gmail.com> Content-Type: multipart/alternative; boundary=Apple-Mail-101-894484187 Mime-Version: 1.0 (Apple Message framework v924) Subject: Re: svn commit: r666816 - in /geronimo/server/trunk/plugins/tomcat/geronimo-tomcat6/src/main/java/org/apache/geronimo/tomcat/connector: Http11APRConnectorGBean.java Http11APRProtocol.java Date: Thu, 12 Jun 2008 20:30:01 +0700 References: <20080611200137.D971023889BA@eris.apache.org> <9BF37F50-2008-4665-930B-EE9E39C90F1B@gmail.com> X-Mailer: Apple Mail (2.924) Sender: Jason Dillon X-Virus-Checked: Checked by ClamAV on apache.org --Apple-Mail-101-894484187 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit http://svn.collab.net/repos/svn/trunk/contrib/client-side/svn_apply_autoprops.py --jason On Jun 12, 2008, at 7:58 PM, Kevan Miller wrote: > Hi Lin, > Thanks for reverting and recommitting the change. This problem > wasn't your fault. It was the fault of whoever created these files > in svn. > > See http://cwiki.apache.org/GMOxDEV/subversion-client-configuration.html > for information about svn client configuration for our project. > > As specified in this file, .java files should have the following > properties: > > *.java = svn:mime-type=text/plain;svn:eol- > style=native;svn:keywords=Date Revision > > Only AJP13ConnectorGBean.java has these properties. The other files > have no properties at all. To prevent these problems in the future, > we should set these properties on all of the files. > > I recall a script file which could be used to scan a code tree and > look for non-conforming files, but don't recall what/where it is. > Perhaps someone else can chime in... > > --kevan > > > On Jun 11, 2008, at 4:01 PM, linsun@apache.org wrote: > >> Author: linsun >> Date: Wed Jun 11 13:01:37 2008 >> New Revision: 666816 >> >> URL: http://svn.apache.org/viewvc?rev=666816&view=rev >> Log: >> GERONIMO-4114 - newly created APR HTTPS connector failed to start - >> hopefully i got the svn property right this time! >> >> Modified: >> geronimo/server/trunk/plugins/tomcat/geronimo-tomcat6/src/main/ >> java/org/apache/geronimo/tomcat/connector/ >> Http11APRConnectorGBean.java >> geronimo/server/trunk/plugins/tomcat/geronimo-tomcat6/src/main/ >> java/org/apache/geronimo/tomcat/connector/Http11APRProtocol.java >> >> Modified: geronimo/server/trunk/plugins/tomcat/geronimo-tomcat6/src/ >> main/java/org/apache/geronimo/tomcat/connector/ >> Http11APRConnectorGBean.java >> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/tomcat/geronimo-tomcat6/src/main/java/org/apache/geronimo/tomcat/connector/Http11APRConnectorGBean.java?rev=666816&r1=666815&r2=666816&view=diff >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- geronimo/server/trunk/plugins/tomcat/geronimo-tomcat6/src/main/ >> java/org/apache/geronimo/tomcat/connector/ >> Http11APRConnectorGBean.java (original) >> +++ geronimo/server/trunk/plugins/tomcat/geronimo-tomcat6/src/main/ >> java/org/apache/geronimo/tomcat/connector/ >> Http11APRConnectorGBean.java Wed Jun 11 13:01:37 2008 >> @@ -114,6 +114,10 @@ >> Object value = connector.getAttribute("useSendfile"); >> return value == null ? true : new >> Boolean(value.toString()).booleanValue(); >> } >> + >> + public String getSslPassword() { >> + return (String) connector.getAttribute("SSLPassword"); >> + } >> >> public void setPollTime(int pollTime) { >> connector.setAttribute("pollTime", pollTime); >> >> Modified: geronimo/server/trunk/plugins/tomcat/geronimo-tomcat6/src/ >> main/java/org/apache/geronimo/tomcat/connector/Http11APRProtocol.java >> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/tomcat/geronimo-tomcat6/src/main/java/org/apache/geronimo/tomcat/connector/Http11APRProtocol.java?rev=666816&r1=666815&r2=666816&view=diff >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- geronimo/server/trunk/plugins/tomcat/geronimo-tomcat6/src/main/ >> java/org/apache/geronimo/tomcat/connector/Http11APRProtocol.java >> (original) >> +++ geronimo/server/trunk/plugins/tomcat/geronimo-tomcat6/src/main/ >> java/org/apache/geronimo/tomcat/connector/Http11APRProtocol.java >> Wed Jun 11 13:01:37 2008 >> @@ -39,6 +39,7 @@ >> public void setSslCertificateFile(String sslCertificateFile); >> public String getSslCertificateKeyFile(); >> public void setSslCertificateKeyFile(String >> sslCertificateKeyFile); >> + public String getSslPassword(); >> public void setSslPassword(String sslPassword); >> public String getSslVerifyClient(); >> public void setSslVerifyClient(String sslVerifyClient); >> >> > --Apple-Mail-101-894484187 Content-Type: text/html; charset=US-ASCII Content-Transfer-Encoding: quoted-printable http://svn.collab.net/repos/svn/trunk/contrib/client-side/= svn_apply_autoprops.py

--jason

=

On Jun 12, 2008, at 7:58 PM, Kevan Miller = wrote:

Hi Lin,
Thanks for = reverting and recommitting the change. This problem wasn't your fault. = It was the fault of whoever created these files in = svn. 









Author:= linsun
Date: Wed Jun 11 13:01:37 2008
New Revision: = 666816

URL: http://s= vn.apache.org/viewvc?rev=3D666816&view=3Drev
Log:
GERONIMO-4= 114 - newly created APR HTTPS connector failed to start - hopefully i = got the svn property right this time!

Modified:
=    geronimo/server/trunk/plugins/tomcat/geronimo-tomcat6/sr= c/main/java/org/apache/geronimo/tomcat/connector/Http11APRConnectorGBean.j= ava
=    geronimo/server/trunk/plugins/tomcat/geronimo-tomcat6/sr= c/main/java/org/apache/geronimo/tomcat/connector/Http11APRProtocol.java
Modified: = geronimo/server/trunk/plugins/tomcat/geronimo-tomcat6/src/main/java/org/ap= ache/geronimo/tomcat/connector/Http11APRConnectorGBean.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/tomc= at/geronimo-tomcat6/src/main/java/org/apache/geronimo/tomcat/connector/Htt= p11APRConnectorGBean.java?rev=3D666816&r1=3D666815&r2=3D666816&= ;view=3Ddiff
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- = geronimo/server/trunk/plugins/tomcat/geronimo-tomcat6/src/main/java/org/ap= ache/geronimo/tomcat/connector/Http11APRConnectorGBean.java = (original)
+++ = geronimo/server/trunk/plugins/tomcat/geronimo-tomcat6/src/main/java/org/ap= ache/geronimo/tomcat/connector/Http11APRConnectorGBean.java Wed Jun 11 = 13:01:37 2008
@@ -114,6 +114,10 @@
=         Object value =3D = connector.getAttribute("useSendfile");
=         return value =3D=3D null = ? true : new Boolean(value.toString()).booleanValue();
=     }
+    
+ =    public String getSslPassword() {
+ =        return (String) = connector.getAttribute("SSLPassword");
+    }

=     public void setPollTime(int pollTime) {
=         connector.setAttribute("po= llTime", pollTime);

Modified: = geronimo/server/trunk/plugins/tomcat/geronimo-tomcat6/src/main/java/org/ap= ache/geronimo/tomcat/connector/Http11APRProtocol.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/tomcat/ger= onimo-tomcat6/src/main/java/org/apache/geronimo/tomcat/connector/Http11APR= Protocol.java?rev=3D666816&r1=3D666815&r2=3D666816&view=3Ddiff=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D
--- = geronimo/server/trunk/plugins/tomcat/geronimo-tomcat6/src/main/java/org/ap= ache/geronimo/tomcat/connector/Http11APRProtocol.java (original)
+++ = geronimo/server/trunk/plugins/tomcat/geronimo-tomcat6/src/main/java/org/ap= ache/geronimo/tomcat/connector/Http11APRProtocol.java Wed Jun 11 = 13:01:37 2008
@@ -39,6 +39,7 @@
    public = void setSslCertificateFile(String sslCertificateFile);
=     public String getSslCertificateKeyFile();
=     public void setSslCertificateKeyFile(String = sslCertificateKeyFile);
+    public String = getSslPassword();
    public void = setSslPassword(String sslPassword);
    public = String getSslVerifyClient();
    public void = setSslVerifyClient(String = sslVerifyClient);




= --Apple-Mail-101-894484187--