From dev-return-63805-apmail-geronimo-dev-archive=geronimo.apache.org@geronimo.apache.org Mon Jun 02 23:26:01 2008 Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 78020 invoked from network); 2 Jun 2008 23:26:01 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 2 Jun 2008 23:26:01 -0000 Received: (qmail 33647 invoked by uid 500); 2 Jun 2008 23:26:02 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 33593 invoked by uid 500); 2 Jun 2008 23:26:02 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 33582 invoked by uid 99); 2 Jun 2008 23:26:02 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Jun 2008 16:26:02 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [98.136.44.59] (HELO smtp104.prem.mail.sp1.yahoo.com) (98.136.44.59) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 02 Jun 2008 23:25:12 +0000 Received: (qmail 20112 invoked from network); 2 Jun 2008 23:25:29 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:Message-Id:From:To:In-Reply-To:Content-Type:Content-Transfer-Encoding:Mime-Version:Subject:Date:References:X-Mailer; b=YcTurzyebeZGB6Bj4d4HOPTpsJICoFcGkXR3WWHL44YIDJLDBEat4DJZEQeneCScNSQ4rCCtQvfdGLaTxcDyqJCdm+7Dt9rEPOHi14X7QJeEI00WMw45QGumc66sY8QLteG8uB3P9XgGeFh53nC3LQT5JeioPWfT9496lXGaqsg= ; Received: from unknown (HELO ?10.11.55.42?) (david_jencks@63.105.20.225 with plain) by smtp104.prem.mail.sp1.yahoo.com with SMTP; 2 Jun 2008 23:25:28 -0000 X-YMail-OSG: TRa5_gkVM1mDpB8u9N_Sy0Gjg998n.kvr.OM3MZJIAluXq8miqKNNzkF8dQWouGnA.U5B4RWyPhKIhkWoiDTqwxVqhAqPdvpXqIELTPf_or0p2u_sgs0BS24a5A- X-Yahoo-Newman-Property: ymail-3 Message-Id: <26976FEB-F1F4-4E25-B371-DC70397BEA01@yahoo.com> From: David Jencks To: dev@geronimo.apache.org In-Reply-To: <484463E7.6050300@earthlink.net> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v919.2) Subject: Re: svn commit: r660588 [1/3] - in /geronimo/samples/trunk: ./ samples/ samples/CustomerService/CustomerService-ear/ samples/CustomerService/CustomerService-ear/src/main/resources/ samples/CustomerService/CustomerService-ear/src/main/resources/META-INF/ sa... Date: Mon, 2 Jun 2008 16:25:26 -0700 References: <20080527163047.3C1DD2388A0B@eris.apache.org> <484463E7.6050300@earthlink.net> X-Mailer: Apple Mail (2.919.2) X-Virus-Checked: Checked by ClamAV on apache.org On Jun 2, 2008, at 2:19 PM, Joe Bohn wrote: > > David, > > I see in this change (one sample shown below but changed on nearly > all samples) that you removed the prereq on tomcat/jetty from the > respective plugins. > > I understand that you did this so that the samples could be > installed in just a framework server (esp. for the integration tests). > > However, I wonder if this is a good move for the user. With this > change, a user viewing the sample plugins available for install on a > jetty server instance will see all of the jetty sample plugins and > all the tomcat sample plugins marked ready to install. Likewise, > all of the jetty plugins are available for installation on a tomcat > server image. > > The framework case is not a common case for installing these samples > (at least I suspect it is not for most users). Most users will use > the more popular tomcat or jetty assemblies. If they choose to > install a sample plugin for tomcat on a jetty server I suspect they > would end up with 2 web containers in the server image and many > problems. Is that correct? yes (although I haven't personally tried it) > Perhaps we should add the pre-reqs back in (at least for samples) > and update the integration tests to use just one web container? > What do you think? I think we should keep it as it is. I think the most common use for the samples might be running the servers assembled in the *-jetty/ target directories that have the apps installed. no muss no fuss. This is a generic problem we have for all plugins, not just the samples. I don't see why we should make the samples more restricted than for instance the console plugins. thanks david jencks > > > Joe > > > > djencks@apache.org wrote: > > >> Modified: geronimo/samples/trunk/samples/CustomerService/ >> CustomerService-jetty/pom.xml >> URL: http://svn.apache.org/viewvc/geronimo/samples/trunk/samples/CustomerService/CustomerService-jetty/pom.xml?rev=660588&r1=660587&r2=660588&view=diff >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- geronimo/samples/trunk/samples/CustomerService/CustomerService- >> jetty/pom.xml (original) >> +++ geronimo/samples/trunk/samples/CustomerService/CustomerService- >> jetty/pom.xml Tue May 27 09:29:53 2008 > > > Sample >> >> >> - >> - >> - >> org.apache.geronimo.configs >> - jetty6 >> - >> - Web Container> resource-type> >> - >> - This version of the >> application works with the Geronimo/Jetty distribution. >> - It is not intended to run in >> the Geronimo/Tomcat distribution. >> - There is a separate version of >> the application that works with Tomcat. >> - Please install the version >> appropriate to your Geronimo distribution. >> - >> - >> + >> + >> + >> + >> + >> + >> + >> + >> + >> + >> + >> + >> + > > >