geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lin Sun" <linsun....@gmail.com>
Subject Re: svn commit: r669506 - /geronimo/server/trunk/framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java
Date Thu, 19 Jun 2008 19:51:10 GMT
I agree I've been always wondering if the assembly zip file is wrong!   :-)

I can change the behavior to warn the users when we don't find the
config-substitutions.properties file before David has time to look
into a better solution.   I don't think adding the
config-substitutions.properties file to
geronimo-boilerplate-minimal.jar would work, as the filenotfound
exception was thrown when the PluginInstallerGBean is initialized and
at that time the system doesn't have any files under
var\temp\assembly\var\config yet.

I'll also try add some instructions in the beginning of the
config-substitutions.properties file.  looks like it can be done in
the storeConfigSubstitutions method of LocalAttributeManager.

thanks, Lin



On Thu, Jun 19, 2008 at 1:26 PM, Kevan Miller <kevan.miller@gmail.com> wrote:

> They look like "errors" to me ;-P. And disagree that they are harmless. As
> described in the jira, this is not just during a "build" (i.e. while running
> mvn). It happens when exporting an assembly from a running server. I think
> users would justifiably think that something has gone wrong.
> That said, I also agree that it's better to inform users when we don't find
> a config-substitutions.properties file.
> The appropriate solution, IMO, is to include a
> config-substitutions.properties file in geronimo-boilerplate-minimal.jar. I
> think everyone will be happy, then.
> Just tried this (added a
> zero-length geronimo-boilerplate-minimal/src/main/underlay/var/config/config-substitutions.properties
> file). It causes a problem in the geronimo-framework assembly -- we don't
> write out any properties and framework server start-up fails. We write out
> properties for in the tomcat/jetty assemblies, but they don't contain
> framework properties. I'd guess that we can fix this problem, pretty
> easily...
> While we're at it, perhaps we can add a comment to
> config-substitutions.properties that indicates it's usage? The README.txt
> talks about it, but useful to have a little doc in the file itself...
> --kevan
>
>
>
> thanks
>
> david jencks
>
> On Jun 19, 2008, at 8:49 AM, Jarek Gawor wrote:
>
> Lin,
>
> I wonder if we should instead log a warning when the file was
>
> specified but not found. With this change and in most cases where
>
> LocalAttributeManager is used, the user will have no idea that the
>
> file was not read (and later might result in weird exceptions as the
>
> variables in config.xml did not get resolved). Or maybe we need to do
>
> something special for the "assemble the server" case since these
>
> FilleNotFound errors are only visible there.
>
> Jarek
>
> On Thu, Jun 19, 2008 at 11:27 AM,  <linsun@apache.org> wrote:
>
> Author: linsun
>
> Date: Thu Jun 19 08:27:35 2008
>
> New Revision: 669506
>
> URL: http://svn.apache.org/viewvc?rev=669506&view=rev
>
> Log:
>
> GERONIMO-3971 - Error message during assembling a server
>
> Modified:
>
> geronimo/server/trunk/framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java
>
> Modified:
>
> geronimo/server/trunk/framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java
>
> URL:
>
> http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java?rev=669506&r1=669505&r2=669506&view=diff
>
> ==============================================================================
>
> ---
>
> geronimo/server/trunk/framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java
>
> (original)
>
> +++
>
> geronimo/server/trunk/framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java
>
> Thu Jun 19 08:27:35 2008
>
> @@ -615,7 +615,7 @@
>
>  private static Properties loadConfigSubstitutions(File
>
> configSubstitutionsFile) {
>
>      Properties properties = new Properties();
>
> -        if (configSubstitutionsFile != null) {
>
> +        if (configSubstitutionsFile != null &&
>
> configSubstitutionsFile.exists()) {
>
>          try {
>
>              FileInputStream in = new
>
> FileInputStream(configSubstitutionsFile);
>
>              try {
>
>
>
>
>
>
>

Mime
View raw message