geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Jencks <david_jen...@yahoo.com>
Subject Re: svn commit: r669506 - /geronimo/server/trunk/framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java
Date Thu, 19 Jun 2008 15:59:07 GMT
I agree with Jarek, -1 on this change.  The warnings during the build  
are fairly harmless.  Ideally we could figure out how to make the file  
be there before we try to access it during server assembly.  I'd be be  
ok with logging an error but slightly prefer the current exception  
unless we find there is no good way to create the file before it is  
needed.

thanks
david jencks

On Jun 19, 2008, at 8:49 AM, Jarek Gawor wrote:

> Lin,
>
> I wonder if we should instead log a warning when the file was
> specified but not found. With this change and in most cases where
> LocalAttributeManager is used, the user will have no idea that the
> file was not read (and later might result in weird exceptions as the
> variables in config.xml did not get resolved). Or maybe we need to do
> something special for the "assemble the server" case since these
> FilleNotFound errors are only visible there.
>
> Jarek
>
> On Thu, Jun 19, 2008 at 11:27 AM,  <linsun@apache.org> wrote:
>> Author: linsun
>> Date: Thu Jun 19 08:27:35 2008
>> New Revision: 669506
>>
>> URL: http://svn.apache.org/viewvc?rev=669506&view=rev
>> Log:
>> GERONIMO-3971 - Error message during assembling a server
>>
>> Modified:
>>   geronimo/server/trunk/framework/modules/geronimo-system/src/main/ 
>> java/org/apache/geronimo/system/configuration/ 
>> LocalAttributeManager.java
>>
>> Modified: geronimo/server/trunk/framework/modules/geronimo-system/ 
>> src/main/java/org/apache/geronimo/system/configuration/ 
>> LocalAttributeManager.java
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java?rev=669506&r1=669505&r2=669506&view=diff
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> =====================================================================
>> --- geronimo/server/trunk/framework/modules/geronimo-system/src/ 
>> main/java/org/apache/geronimo/system/configuration/ 
>> LocalAttributeManager.java (original)
>> +++ geronimo/server/trunk/framework/modules/geronimo-system/src/ 
>> main/java/org/apache/geronimo/system/configuration/ 
>> LocalAttributeManager.java Thu Jun 19 08:27:35 2008
>> @@ -615,7 +615,7 @@
>>
>>    private static Properties loadConfigSubstitutions(File  
>> configSubstitutionsFile) {
>>        Properties properties = new Properties();
>> -        if (configSubstitutionsFile != null) {
>> +        if (configSubstitutionsFile != null &&  
>> configSubstitutionsFile.exists()) {
>>            try {
>>                FileInputStream in = new  
>> FileInputStream(configSubstitutionsFile);
>>                try {
>>
>>
>>


Mime
View raw message