geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Leong (JIRA)" <j...@apache.org>
Subject [jira] Commented: (GERONIMO-4158) Plan Creator attempts to load old widget files after dijit migration
Date Wed, 25 Jun 2008 14:58:46 GMT

    [ https://issues.apache.org/jira/browse/GERONIMO-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608068#action_12608068
] 

Joseph Leong commented on GERONIMO-4158:
----------------------------------------

Hi Shiva,

This is nothing complicated by any stretch, and me just nitpicking to make the little things
a little better.

Correct me if i'm wrong, my apologies as i'm still learning about dojo, but on plugins/plancreator/plancreator-portlets/src/main/webapp/WEB-INF/view/configcreator/ejbPage.jsp

There is a list of dojo.require of widgets.  Looking at all the other files and how everything
is now run on Dojo 1.1.1 with Dijit. That extra loading isn't necessary anymore? Also the
dependency on them will be obsolete soon - also i believe that src is pointing to the location
of 1.1.1 where the widgets don't reside anymore since they've been move to dojo/0.4/?

If you can can confirm that, i'll submit a simple patch to clean that up and make sure nothing
else is dependent on it.

Thanks!

-Joseph Leong

> Plan Creator attempts to load old widget files after dijit migration
> --------------------------------------------------------------------
>
>                 Key: GERONIMO-4158
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4158
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: PlanCreator
>    Affects Versions: 2.2
>         Environment: Ubuntu 7.10, Firefox
>            Reporter: Joseph Leong
>            Assignee: Joseph Leong
>            Priority: Trivial
>             Fix For: 2.2
>
>
> The plancreator-portlets has some leftover code that allocates resources for loading
the old widget system which will soon be removed.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message