Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Received-SPF: pass (athena.apache.org: domain of jgawor@gmail.com designates
 64.233.170.188 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=jouKBj2/UbO6RY5Rh1FbNgq8uNueEI/GRKFaTxDNOUcU1ezJOOeZQyyJnyK0VZTif11LBge6eiDCdQUOl3G/Zayf43grKdhHgFAvBMYYKXP0f9J0gVmxyejJlyTtgdAGfSZns51BWI+UrORD9gDCeA6voXingGbqIRAFdc6iYK0=
Message-ID: <5eb405c70805290809u7b05ccb8k8d831dc31c3385d7@mail.gmail.com>
Date: Thu, 29 May 2008 11:09:15 -0400
From: "Jarek Gawor" <jgawor@gmail.com>
To: dev@geronimo.apache.org
Subject: Re: svn commit: r661343 -
 /geronimo/server/branches/2.1/framework/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java
In-Reply-To: <20080529145943.D470A2388A0A@eris.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20080529145943.D470A2388A0A@eris.apache.org>

Since the DeploymentManagerCreationException  (or
AuthenticationFailedException) is initialized with .initCause(e) of
the root exception why log the root exception and the new exception?
Logging of DeploymentManagerCreationException or
AuthenticationFailedException should be enough (which will include the
root exception).

Jarek

On Thu, May 29, 2008 at 10:59 AM,  <jawarner@apache.org> wrote:
> Author: jawarner
> Date: Thu May 29 07:59:43 2008
> New Revision: 661343
>
> URL: http://svn.apache.org/viewvc?rev=661343&view=rev
> Log:
> GERONIMO-4087: Improve usability of gshell commands deploy/* when failing to connect to server
>
> Modified:
>    geronimo/server/branches/2.1/framework/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java
>
> Modified: geronimo/server/branches/2.1/framework/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java
> URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.1/framework/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java?rev=661343&r1=661342&r2=661343&view=diff
> ==============================================================================
> --- geronimo/server/branches/2.1/framework/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java (original)
> +++ geronimo/server/branches/2.1/framework/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java Thu May 29 07:59:43 2008
> @@ -178,10 +178,14 @@
>             }
>             return manager;
>         } catch (IOException e) {
> -            log.fatal("caught ", e);
> +               if (log.isDebugEnabled()) {
> +                log.debug("caught ", e);
> +               }
>             DeploymentManagerCreationException deploymentManagerCreationException =
>                     (DeploymentManagerCreationException) new DeploymentManagerCreationException(e.getMessage()).initCause(e);
> -            log.fatal("throwing ", deploymentManagerCreationException);
> +            if (log.isDebugEnabled()) {
> +                log.debug("throwing ", deploymentManagerCreationException);
> +            }
>             throw deploymentManagerCreationException;
>         } catch (SecurityException e) {
>             if (log.isDebugEnabled()) {
>
>
>