geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Jencks <>
Subject Re: Need some advice on how to include repository/* bits in the boilerplate
Date Wed, 14 May 2008 07:38:38 GMT

On May 13, 2008, at 6:02 PM, Donald Woods wrote:

> Attached patch includes other changes, like moving to jaxb 2.1, some  
> security changes, ....

I thought I left out the security changes, sorry.  Comes from trying  
to do too many things at once :-(
> Other comments attached to GERONIMO-4013.

I may have been unclear.  I wasn't suggesting my initial GERONIMO-4013  
patch was suitable to be committed, but that it might let us figure  
out some of the problems with  the idea of the car-maven-plugin  
including maven transitive dependencies before we broke everything at  
once.  In particular it looks to me as if the dependencies for the  
gshell-* plugins are too all-inclusive and was wondering what to do  
about this.

For instance, I have no problem with removing gshell-embeddable, but  
would prefer to get the car-maven-plugin working better before  
attacking that problem.

david jencks

> -Donald
> David Jencks wrote:
>> I've attached a patch to GERONIMO-4013 that reverses the changes  
>> from 4012 and change the car-maven-plugin to optionally follow  
>> transitive dependencies.  I think if you apply my patch you won't  
>> be using the gshell-* plugins.  I had to make a couple other minor  
>> build changes to get the build to complete.  The server builds and  
>> shows signs of starting -- on my copy it runs into some problems  
>> with unrelated changes to the security system I'm working on.
>> Jason, can you check the generated dependencies in the gshell-*  
>> plugins to see if they look remotely plausible or can be nudged  
>> closer to plausible?
>> thanks
>> david jencks
>> On May 13, 2008, at 11:55 AM, David Jencks wrote:
>>> I talked with jason a bit on irc and we're doing an experiment  
>>> with optionally including transitive dependencies using the car- 
>>> maven-plugin.  Hopefully this will work and avoid the duplication  
>>> jason is leery of.  Please don't commit duplication until we find  
>>> out if this works or not.
>>> AFAICT this isn't a bug fix but rather new development so I'm  
>>> unclear about why you are thinking of including this in 2.1.2?
>>> thanks
>>> david jencks
>>> On May 13, 2008, at 11:32 AM, Donald Woods wrote:
>>>> I started with your new framework/configs/gshell-* code, updated  
>>>> gshell-framework to include all the individual depends so we  
>>>> don't need gshell-embeddable, updated server/pom.xml with the new  
>>>> depends and updated boilerplate with the new gshell-geronimo car  
>>>> depend and it looks promising.  I'm still exercising some of the  
>>>> gsh commands, but so far help, geronimo/start-server, deploy/ 
>>>> connect and geronimo/stop-server are working....
>>>> If all looks well after a few more tests, I'll commit the changes  
>>>> into trunk for everyone to review before we spend the time  
>>>> pulling it into 2.1.2.
>>>> -Donald
>>>> Jason Dillon wrote:
>>>>> On May 13, 2008, at 1:14 AM, David Jencks wrote:
>>>>>> So including the dependencies you need for gshell in the  
>>>>>> boilerplate's pom would get them into the geronimo repo.  As I  
>>>>>> said transitive dependencies don't result in inclusion at the  
>>>>>> moment for rather good reasons.  I don't know what the  
>>>>>> <include> tag would do but it's probably worth investigating.
>>>>> What <include> tag are you talking about?
>>>>> I guess I'm gonna try to make plugins for the gshell  
>>>>> dependencies, these 3:
>>>>>  gshell-framework - just the core bits required to make gshell  
>>>>> work
>>>>>  gshell-geronimo - our additional commands to work with the  
>>>>> server + their deps
>>>>>  gshell-remote - the remote/whisper commands
>>>>> I must say I'm really quite frustrated at the lack of transitive  
>>>>> dependency support here.  As this means that alot of the  
>>>>> dependencyManagement configuration which is already in the  
>>>>> GShell poms need to be duplicated into the Geronimo poms, making  
>>>>> version management even more of a nightmare.
>>>>> :-(
>>>>> Well, I started to add these cars to framework/configs, but I  
>>>>> must admit I really am clueless for how this stuff works now.
>>>>> :-(
>>>>> --jason

View raw message