Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Received-SPF: pass (athena.apache.org: domain of vmzakhar@gmail.com designates
 209.85.200.174 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
        b=xxUcoz7P8DlL0n3UoxhGc1lsSCTg6gX72Wf9Ol4wdlHODkeREedIZ/k3pqCowa0IIG4K2q6H2nEKQKQqeY+hStluF5Y0T+a5/+hVwZ21ycFLv6mh+1QzkJkzSdCmry+XmXzc/mb72OlYf7/ASTdTY00etl6ENuJqo4TbelBlY14=
Message-ID: <bd849a5d0804101103m7fda8a02ve075077c1de4b123@mail.gmail.com>
Date: Thu, 10 Apr 2008 20:03:39 +0200
From: "Vasily Zakharov" <vmz@apache.org>
Sender: vmzakhar@gmail.com
To: dev@geronimo.apache.org
Subject: Re: Updating svn:ignore lists
In-Reply-To: <73a75e430804101055p7bdcee82j29259e5fc187e077@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <bd849a5d0804101015p749730eaj5cecc9b50233707a@mail.gmail.com>
	 <73a75e430804101018w53916d3dp602d375aaafbed1b@mail.gmail.com>
	 <bd849a5d0804101047v1aa08b68nb94994eb463e5c2b@mail.gmail.com>
	 <73a75e430804101055p7bdcee82j29259e5fc187e077@mail.gmail.com>

No, I don't think is a Tortoise problem indeed.
It just proposes to add to the patch all new (not added to SVN) files
it sees in the working directory unless they're put to svn:ignore
lists.
Looks pretty logical and intuitive to me. :)

Anyway, I'm not crying in despair :), I just see that in some cases
svn:ignore lists are properly maintained and include all the generated
directories, and in some cases they're not, and I think that it
probably worths to be consistent in this matter. :)

Vasily


On Thu, Apr 10, 2008 at 7:55 PM, Jason Warner <jaw981@gmail.com> wrote:
> Alright.  I was just curious why you were seeing an issue I wasn't.  Now
> that I see you're using TortoiseSVN it all becomes clear ;)  I liked
> tortoiseSVN's interface, it just has little bugs here and there that got on
> my nerves too much.  I'm inclined to think the issue is in how tortoiseSVN
> is handling creating patches.  I'm not opposed to the change, though.  Just
> curious, is all.  Thanks for the info!
>
> ~Jason Warner
>
>
>
> On Thu, Apr 10, 2008 at 1:47 PM, Vasily Zakharov <vmz@apache.org> wrote:
> > Well, I'm using TortoiseSVN and it always considers those files to be
> > added to the repository when I'm going to create a patch.
> > This obstructs a create patch/commit dialog with a lot of unneeded
> > entries, and increases the working copy scan time.
> >
> > In fact, I wouldn't raise this issue if I don't see that many other
> > 'target' and 'build' directories are put to svn:ignore lists, while
> > some are not.
> >
> > Vasily
> >
> >
> >
> >
> >
> > On Thu, Apr 10, 2008 at 7:18 PM, Jason Warner <jaw981@gmail.com> wrote:
> > > Hi Vasily,
> > >
> > > What do you mean by getting in the way?  I've never had issues with
> this.
> > > What behavior are you seeing?
> > >
> > > ~Jason Warner
> > >
> > >
> > >
> > > On Thu, Apr 10, 2008 at 1:15 PM, Vasily Zakharov <vmz@apache.org> wrote:
> > >
> > > > When trying to create a patch in an already-built environment, a lot
> > > > of build-generated directories get in the way.
> > > > Probably they need to be added to the corresponding SVN ignore lists.
> > > >
> > > > I've created a GERONIMO-3957 for that, and provided patches for trunk,
> > > > branches/2.1, branches/2.0 and tags/2.1.0.
> > > >
> > > > I hope it would be useful.
> > > >
> > > > Vasily
> > > >
> > >
> > >
> > >
> > > --
> > > ~Jason Warner
> >
>
>
>
> --
> ~Jason Warner