Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 19733 invoked from network); 27 Apr 2008 10:43:27 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 27 Apr 2008 10:43:26 -0000 Received: (qmail 35298 invoked by uid 500); 27 Apr 2008 10:43:27 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 35239 invoked by uid 500); 27 Apr 2008 10:43:27 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 35228 invoked by uid 99); 27 Apr 2008 10:43:27 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Apr 2008 03:43:27 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jason.dillon@gmail.com designates 209.85.146.179 as permitted sender) Received: from [209.85.146.179] (HELO wa-out-1112.google.com) (209.85.146.179) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Apr 2008 10:42:42 +0000 Received: by wa-out-1112.google.com with SMTP id j4so6390906wah.1 for ; Sun, 27 Apr 2008 03:42:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:from:to:in-reply-to:content-type:content-transfer-encoding:mime-version:subject:date:references:x-mailer:sender; bh=7q/A6+sCn/YeFbyrf+87mI1Td6ZpLcZjZxbw/0MkxSU=; b=UczuS3LMdbYE3lGZ/Bw2ulPsrppy+XFm8NuXXCEqrLJQxrqkheSuIOumIfERHeqj/JvnnrwVX2dpZrBNgGdR+DStT2tKD8IT7AblN8ZEPKljd01TT5YZSoD0e2t/hYut8EoU2aOM5lh9211rWxQYChqJBB8MN+GUIshTrLqIj2I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:from:to:in-reply-to:content-type:content-transfer-encoding:mime-version:subject:date:references:x-mailer:sender; b=hy+kJ8X2wCxjzf92Tl0rSujnIuOaAZs4pS7J/ej7/62v77BQ3Qb27QsuhEY1MKmy4NiVwDqRR3aMCye0wVQ4gT9Mqove/i8P7C1YUCBxE+ZywRSjm1VCTJ3nYoqt3tV1y8fmPG6NOyebbV1Vy7V+j5gt7brTDfy78ORlYvKMGa8= Received: by 10.114.191.12 with SMTP id o12mr5219788waf.224.1209292975397; Sun, 27 Apr 2008 03:42:55 -0700 (PDT) Received: from ?10.0.1.98? ( [58.8.7.189]) by mx.google.com with ESMTPS id n22sm7408456pof.13.2008.04.27.03.42.52 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 27 Apr 2008 03:42:54 -0700 (PDT) Message-Id: <74DA14FD-B8E0-4EB2-83A5-28D3295D0744@planet57.com> From: Jason Dillon To: dev@geronimo.apache.org In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v919.2) Subject: Re: svn commit: r651912 - in /geronimo/server/trunk/framework/modules/geronimo-naming/src/main/java/org/apache/geronimo/gjndi: KernelContextGBean.java binding/GBeanBinding.java binding/GBeanFormatBinding.java Date: Sun, 27 Apr 2008 17:42:48 +0700 References: <20080427102044.98EA41A981C@eris.apache.org> X-Mailer: Apple Mail (2.919.2) Sender: Jason Dillon X-Virus-Checked: Checked by ClamAV on apache.org Ya, I think so... I *ucked up when I did the conversion. Though using instance loggers does provide more ability to provide context specific logging muck, and is recommended by the SLF4J docs. But I'm finding some problem with GBean serialization... trying to track it down. IMO instance loggers are preferable, but parts of the system need the statics... :-\ --jason On Apr 27, 2008, at 5:31 PM, Gianny Damour wrote: > The same goes for many many logs no? > > Thanks, > Gianny > > On 27/04/2008, at 8:20 PM, jdillon@apache.org wrote: > >> Author: jdillon >> Date: Sun Apr 27 03:20:35 2008 >> New Revision: 651912 >> >> URL: http://svn.apache.org/viewvc?rev=651912&view=rev >> Log: >> Make loggers static again >> >> Modified: >> geronimo/server/trunk/framework/modules/geronimo-naming/src/main/ >> java/org/apache/geronimo/gjndi/KernelContextGBean.java >> geronimo/server/trunk/framework/modules/geronimo-naming/src/main/ >> java/org/apache/geronimo/gjndi/binding/GBeanBinding.java >> geronimo/server/trunk/framework/modules/geronimo-naming/src/main/ >> java/org/apache/geronimo/gjndi/binding/GBeanFormatBinding.java >> >> Modified: geronimo/server/trunk/framework/modules/geronimo-naming/ >> src/main/java/org/apache/geronimo/gjndi/KernelContextGBean.java >> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-naming/src/main/java/org/apache/geronimo/gjndi/KernelContextGBean.java?rev=651912&r1=651911&r2=651912&view=diff >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- geronimo/server/trunk/framework/modules/geronimo-naming/src/ >> main/java/org/apache/geronimo/gjndi/KernelContextGBean.java >> (original) >> +++ geronimo/server/trunk/framework/modules/geronimo-naming/src/ >> main/java/org/apache/geronimo/gjndi/KernelContextGBean.java Sun Apr >> 27 03:20:35 2008 >> @@ -45,7 +45,7 @@ >> * @version $Rev$ $Date$ >> */ >> public class KernelContextGBean extends WritableContext implements >> GBeanLifecycle { >> - private final Logger log = LoggerFactory.getLogger(getClass()); >> + private static final Logger log = >> LoggerFactory.getLogger(KernelContextGBean.class); >> >> private final Kernel kernel; >> private final AbstractNameQuery abstractNameQuery; >> >> Modified: geronimo/server/trunk/framework/modules/geronimo-naming/ >> src/main/java/org/apache/geronimo/gjndi/binding/GBeanBinding.java >> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-naming/src/main/java/org/apache/geronimo/gjndi/binding/GBeanBinding.java?rev=651912&r1=651911&r2=651912&view=diff >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- geronimo/server/trunk/framework/modules/geronimo-naming/src/ >> main/java/org/apache/geronimo/gjndi/binding/GBeanBinding.java >> (original) >> +++ geronimo/server/trunk/framework/modules/geronimo-naming/src/ >> main/java/org/apache/geronimo/gjndi/binding/GBeanBinding.java Sun >> Apr 27 03:20:35 2008 >> @@ -40,7 +40,7 @@ >> * @version $Rev$ $Date$ >> */ >> public class GBeanBinding implements GBeanLifecycle { >> - private final Logger log = LoggerFactory.getLogger(getClass()); >> + private static final Logger log = >> LoggerFactory.getLogger(GBeanBinding.class); >> >> private final Context context; >> private final String name; >> >> Modified: geronimo/server/trunk/framework/modules/geronimo-naming/ >> src/main/java/org/apache/geronimo/gjndi/binding/ >> GBeanFormatBinding.java >> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-naming/src/main/java/org/apache/geronimo/gjndi/binding/GBeanFormatBinding.java?rev=651912&r1=651911&r2=651912&view=diff >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- geronimo/server/trunk/framework/modules/geronimo-naming/src/ >> main/java/org/apache/geronimo/gjndi/binding/GBeanFormatBinding.java >> (original) >> +++ geronimo/server/trunk/framework/modules/geronimo-naming/src/ >> main/java/org/apache/geronimo/gjndi/binding/GBeanFormatBinding.java >> Sun Apr 27 03:20:35 2008 >> @@ -42,7 +42,7 @@ >> * @version $Rev$ $Date$ >> */ >> public class GBeanFormatBinding extends KernelContextGBean { >> - protected final Logger log = >> LoggerFactory.getLogger(getClass()); >> + protected static final Logger log = >> LoggerFactory.getLogger(GBeanFormatBinding.class); >> private static final Pattern PATTERN = Pattern.compile("(\\{)(\ >> \w+)(})"); >> >> protected final String format; >> >> >