From dev-return-62694-apmail-geronimo-dev-archive=geronimo.apache.org@geronimo.apache.org Fri Apr 25 16:20:23 2008 Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 72622 invoked from network); 25 Apr 2008 16:20:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 25 Apr 2008 16:20:23 -0000 Received: (qmail 38329 invoked by uid 500); 25 Apr 2008 16:20:22 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 38276 invoked by uid 500); 25 Apr 2008 16:20:22 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 38265 invoked by uid 99); 25 Apr 2008 16:20:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Apr 2008 09:20:22 -0700 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [98.136.44.60] (HELO smtp105.prem.mail.sp1.yahoo.com) (98.136.44.60) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 25 Apr 2008 16:19:37 +0000 Received: (qmail 55842 invoked from network); 25 Apr 2008 16:19:49 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:Message-Id:From:To:In-Reply-To:Content-Type:Mime-Version:Subject:Date:References:X-Mailer; b=OH5ArJvGKNchTXQhVmKxTU2Bm51ReLls7VYxy2VZ9L+kYeqfkV7i+kM508FJXlVla+HFTQUtp8Mpt4d2WmnCxc4AE/qL9LY9LEA8WHml+8ninR5ZUAmmRh/VEezSKWf1WVsUZG9PZQFfqHjHUFFZxzexkaFSy8ouzH34VDVepcQ= ; Received: from unknown (HELO ?10.11.55.44?) (david_jencks@63.105.20.225 with plain) by smtp105.prem.mail.sp1.yahoo.com with SMTP; 25 Apr 2008 16:19:49 -0000 X-YMail-OSG: 0ziRJNMVM1mQ8fscJVZhQYao1PRxcW11Jc.vOXFQzj4xu2Gz_Lw0mOcYX9XeaZTkoSfsE63PPaCKRVKWto2Dr3cYZDsfFKgSYr9FYmV7pophfQPgW6wjlAoRKBA- X-Yahoo-Newman-Property: ymail-3 Message-Id: <8EB3F9C4-DB34-4274-9CF2-A5BD818E334C@yahoo.com> From: David Jencks To: dev@geronimo.apache.org In-Reply-To: <73a75e430804250855p67475e61h75ea1f977a928219@mail.gmail.com> Content-Type: multipart/alternative; boundary=Apple-Mail-27-1052437268 Mime-Version: 1.0 (Apple Message framework v919.2) Subject: Re: Committing patches to the subversion repository documentation Date: Fri, 25 Apr 2008 09:19:47 -0700 References: <73a75e430804250855p67475e61h75ea1f977a928219@mail.gmail.com> X-Mailer: Apple Mail (2.919.2) X-Virus-Checked: Checked by ClamAV on apache.org --Apple-Mail-27-1052437268 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit That looks ludicrously overengineered to me. I start with an up to date copy of geronimo, frequently with my own local uncommitted changes in other parts of geronimo, apply the patch, fix conflicts, make sure it works, improve the patch if I see problems, and commit the code relevant to the patch. If the patch is in an area that I'm also working on I use a cleaner copy of geronimo instead of my main working copy. thanks david jencks On Apr 25, 2008, at 8:55 AM, Jason Warner wrote: > This page[1] is labeled as "Do not use" but it hasn't been updated > in over a year. Are these the procedures that we should be > following for committing code? Are there instructions elsewhere > that we should be using instead until these are verified? > > Thanks! > > [1] http://cwiki.apache.org/GMOxDEV/committing-patches-to-the-subversion-repository.html > > > -- > ~Jason Warner --Apple-Mail-27-1052437268 Content-Type: text/html; charset=US-ASCII Content-Transfer-Encoding: quoted-printable That looks ludicrously = overengineered to me.

I start with an up to date copy = of geronimo, frequently with my own local uncommitted changes in other = parts of geronimo, apply the patch, fix conflicts, make sure it works, = improve the patch if I see problems, and commit the code relevant to the = patch.  If the patch is in an area that I'm also working on I use a = cleaner copy of geronimo instead of my main working = copy.

thanks
david = jencks

On Apr 25, 2008, at 8:55 AM, Jason Warner = wrote:

This page[1] is labeled as "Do not use" but it hasn't been = updated in over a year.  Are these the procedures that we should be = following for committing code?  Are there instructions elsewhere = that we should be using instead until these are verified?

Thanks!

[1] http://cwiki.apache.org/GMOxDEV/committing-patches-to-= the-subversion-repository.html


--
~Jason = Warner

= --Apple-Mail-27-1052437268--