geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Dillon <ja...@planet57.com>
Subject Re: svn commit: r651912 - in /geronimo/server/trunk/framework/modules/geronimo-naming/src/main/java/org/apache/geronimo/gjndi: KernelContextGBean.java binding/GBeanBinding.java binding/GBeanFormatBinding.java
Date Sun, 27 Apr 2008 10:42:48 GMT
Ya, I think so... I *ucked up when I did the conversion.  Though using  
instance loggers does provide more ability to provide context specific  
logging muck, and is recommended by the SLF4J docs.  But I'm finding  
some problem with GBean serialization... trying to track it down.

IMO instance loggers are preferable, but parts of the system need the  
statics... :-\

--jason


On Apr 27, 2008, at 5:31 PM, Gianny Damour wrote:

> The same goes for many many logs no?
>
> Thanks,
> Gianny
>
> On 27/04/2008, at 8:20 PM, jdillon@apache.org wrote:
>
>> Author: jdillon
>> Date: Sun Apr 27 03:20:35 2008
>> New Revision: 651912
>>
>> URL: http://svn.apache.org/viewvc?rev=651912&view=rev
>> Log:
>> Make loggers static again
>>
>> Modified:
>>    geronimo/server/trunk/framework/modules/geronimo-naming/src/main/ 
>> java/org/apache/geronimo/gjndi/KernelContextGBean.java
>>    geronimo/server/trunk/framework/modules/geronimo-naming/src/main/ 
>> java/org/apache/geronimo/gjndi/binding/GBeanBinding.java
>>    geronimo/server/trunk/framework/modules/geronimo-naming/src/main/ 
>> java/org/apache/geronimo/gjndi/binding/GBeanFormatBinding.java
>>
>> Modified: geronimo/server/trunk/framework/modules/geronimo-naming/ 
>> src/main/java/org/apache/geronimo/gjndi/KernelContextGBean.java
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-naming/src/main/java/org/apache/geronimo/gjndi/KernelContextGBean.java?rev=651912&r1=651911&r2=651912&view=diff
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> =====================================================================
>> --- geronimo/server/trunk/framework/modules/geronimo-naming/src/ 
>> main/java/org/apache/geronimo/gjndi/KernelContextGBean.java  
>> (original)
>> +++ geronimo/server/trunk/framework/modules/geronimo-naming/src/ 
>> main/java/org/apache/geronimo/gjndi/KernelContextGBean.java Sun Apr  
>> 27 03:20:35 2008
>> @@ -45,7 +45,7 @@
>>  * @version $Rev$ $Date$
>>  */
>> public class KernelContextGBean extends WritableContext implements  
>> GBeanLifecycle {
>> -    private final Logger log = LoggerFactory.getLogger(getClass());
>> +    private static final Logger log =  
>> LoggerFactory.getLogger(KernelContextGBean.class);
>>
>>     private final Kernel kernel;
>>     private final AbstractNameQuery abstractNameQuery;
>>
>> Modified: geronimo/server/trunk/framework/modules/geronimo-naming/ 
>> src/main/java/org/apache/geronimo/gjndi/binding/GBeanBinding.java
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-naming/src/main/java/org/apache/geronimo/gjndi/binding/GBeanBinding.java?rev=651912&r1=651911&r2=651912&view=diff
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> =====================================================================
>> --- geronimo/server/trunk/framework/modules/geronimo-naming/src/ 
>> main/java/org/apache/geronimo/gjndi/binding/GBeanBinding.java  
>> (original)
>> +++ geronimo/server/trunk/framework/modules/geronimo-naming/src/ 
>> main/java/org/apache/geronimo/gjndi/binding/GBeanBinding.java Sun  
>> Apr 27 03:20:35 2008
>> @@ -40,7 +40,7 @@
>>  * @version $Rev$ $Date$
>>  */
>> public class GBeanBinding implements GBeanLifecycle {
>> -    private final Logger log = LoggerFactory.getLogger(getClass());
>> +    private static final Logger log =  
>> LoggerFactory.getLogger(GBeanBinding.class);
>>
>>     private final Context context;
>>     private final String name;
>>
>> Modified: geronimo/server/trunk/framework/modules/geronimo-naming/ 
>> src/main/java/org/apache/geronimo/gjndi/binding/ 
>> GBeanFormatBinding.java
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-naming/src/main/java/org/apache/geronimo/gjndi/binding/GBeanFormatBinding.java?rev=651912&r1=651911&r2=651912&view=diff
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> =====================================================================
>> --- geronimo/server/trunk/framework/modules/geronimo-naming/src/ 
>> main/java/org/apache/geronimo/gjndi/binding/GBeanFormatBinding.java  
>> (original)
>> +++ geronimo/server/trunk/framework/modules/geronimo-naming/src/ 
>> main/java/org/apache/geronimo/gjndi/binding/GBeanFormatBinding.java  
>> Sun Apr 27 03:20:35 2008
>> @@ -42,7 +42,7 @@
>>  * @version $Rev$ $Date$
>>  */
>> public class GBeanFormatBinding extends KernelContextGBean {
>> -    protected final Logger log =  
>> LoggerFactory.getLogger(getClass());
>> +    protected static final Logger log =  
>> LoggerFactory.getLogger(GBeanFormatBinding.class);
>>     private static final Pattern PATTERN = Pattern.compile("(\\{)(\ 
>> \w+)(})");
>>
>>     protected final String format;
>>
>>
>


Mime
View raw message