geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brill Pappin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (GERONIMO-3969) maven2 module goals should use standard server definitions.
Date Sun, 20 Apr 2008 16:12:21 GMT

    [ https://issues.apache.org/jira/browse/GERONIMO-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590783#action_12590783
] 

Brill Pappin commented on GERONIMO-3969:
----------------------------------------

I could try doing the changes, but I usually have trouble building apache modules because
they have so many interlinking dependencies which are not always in repositories I can see
(getting all the bits together and get a build to run can consume a lot of time).

However the Tomcat deploy plugin is fairly simple, and it should be obvious looking at its
source how it's used.
This is what looks to be the relevant pieces if I take a quick look at the SVN repo for the
plugin:

First you instance members:
==
/**
     * The Maven Wagon manager to use when obtaining server authentication
     * details.
     *
     * @parameter expression = "${component.org.apache.maven.artifact.manager.WagonManager}"
     * @required
     * @readonly
     */
    private WagonManager wagonManager;

 /**
     * The server id in settings.xml to use when authenticating with Tomcat
     * manager, or <code>null</code> to use defaults of username
     * <code>admin</code> and no password.
     *
     * @parameter expression = "${maven.tomcat.server}"
     */
    private String server;
==

and then in your execution:

==
 // obtain authenication details for specified server from wagon
                AuthenticationInfo info = wagonManager.getAuthenticationInfo( server );
                if ( info == null )
                {
                    throw new MojoExecutionException( getMessage( "AbstractCatalinaMojo.unknownServer",
server ) );
                }

                // derive username
                userName = info.getUserName();
                if ( userName == null )
                {
                    getLog().debug( getMessage( "AbstractCatalinaMojo.defaultUserName" ) );
                    userName = DEFAULT_USERNAME;
                }

                // derive password
                password = info.getPassword();
                if ( password == null )
                {
                    getLog().debug( getMessage( "AbstractCatalinaMojo.defaultPassword" ) );
                    password = DEFAULT_PASSWORD;
                }
==




> maven2 module goals should use standard server definitions.
> -----------------------------------------------------------
>
>                 Key: GERONIMO-3969
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3969
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: car-maven-plugin, geronimo-maven-plugin
>    Affects Versions: 2.1
>         Environment: Geronimo 2.1
>            Reporter: Brill Pappin
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The maven 2 geronimo plugins should be using the server definitions that are usually
entered in the settings.xml file.
> However it appears that I have to add the administrators username and password to the
plugin definition, which in turn means that some highly secured information will get checked
into source control.
> If it does userthe server definitions, then that fact is not documented on the plugin
site (that I could find). located at: http://geronimo.apache.org/maven/server/maven-plugins/geronimo-maven-plugin/plugin-info.html
> I hesitate to call this a bug because it may still work, but its darn close because of
the security implications (in my case it makes it unusable).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message