Return-Path: 
 <dev-return-61512-apmail-geronimo-dev-archive=geronimo.apache.org@geronimo.apache.org>
Delivered-To: apmail-geronimo-dev-archive@www.apache.org
Received: (qmail 88369 invoked from network); 18 Mar 2008 22:08:18 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 18 Mar 2008 22:08:18 -0000
Received: (qmail 14788 invoked by uid 500); 18 Mar 2008 22:08:13 -0000
Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org
Received: (qmail 14728 invoked by uid 500); 18 Mar 2008 22:08:12 -0000
Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@geronimo.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@geronimo.apache.org>
List-Post: <mailto:dev@geronimo.apache.org>
Reply-To: dev@geronimo.apache.org
List-Id: <dev.geronimo.apache.org>
Delivered-To: mailing list dev@geronimo.apache.org
Received: (qmail 14697 invoked by uid 99); 18 Mar 2008 22:08:12 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Mar 2008 15:08:12 -0700
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Mar 2008 22:07:31 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 73CED234C0AD
	for <dev@geronimo.apache.org>; Tue, 18 Mar 2008 15:06:24 -0700 (PDT)
Message-ID: <1052416244.1205877984473.JavaMail.jira@brutus>
Date: Tue, 18 Mar 2008 15:06:24 -0700 (PDT)
From: "Joe Bohn (JIRA)" <jira@apache.org>
To: dev@geronimo.apache.org
Subject: [jira] Commented: (GERONIMO-2246) Why
 resource-env-ref:admin-object-module?
In-Reply-To: <14182241.1154221933835.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/GERONIMO-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580126#action_12580126 ] 

Joe Bohn commented on GERONIMO-2246:
------------------------------------

Should we move this along to 2.2 given that we have more critical issues for 2.1.1?   Is it still a concern?

> Why resource-env-ref:admin-object-module?
> -----------------------------------------
>
>                 Key: GERONIMO-2246
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-2246
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: connector, deployment
>    Affects Versions: 1.1, 2.0.x, 2.1, 2.1.1
>            Reporter: Aaron Mulder
>            Assignee: David Jencks
>             Fix For: 2.0.x, 2.1.1
>
>
> When mapping resource-env-refs (or a message-destination), It doesn't seem like admin-object-module is necessary.  It can be provided alongside admin-object-name in order to narrow the search down to a specific module within an EAR (the current EAR or any EAR in the dependency graph that has a module with that name).  However, if you need to specify a module, you can just use:
> <pattern>
>     <module>jms.rar</module>
>     <name>foo</name>
> </pattern>
> Instead of using admin-object-module and admin-object-name.  It doesn't seem like this redundancy gets us anything, so I'd rather remove admin-object-module and make admin-object-link work like any other resource/EJB link (name only -- use "pattern" for more complex stuff).
> If we proceed, I don't think we necessarily want to remove it in 1.1.x (breaking backward compatibility with 1.1.0) -- we can remove it in 1.2 and remove message-destination-link at the same time.
> David J, could you comment?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.