geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Dillon <ja...@planet57.com>
Subject Re: svn commit: r641813 - in /geronimo/server/branches/2.1: assemblies/geronimo-boilerplate-minimal/src/main/underlay/ assemblies/geronimo-boilerplate-minimal/src/main/underlay/bin/ buildsupport/geronimo-maven-plugin/src/main/java/org/apache/geronimo/maven...
Date Thu, 27 Mar 2008 16:47:44 GMT
On Mar 27, 2008, at 11:09 PM, Donald Woods wrote:
> "setlocal enableextensions" ensures that long paths are supported  
> correctly on Windows.  We have had it in the geronimo.bat/client.bat  
> scripts for awhile, but the new gsh.bat was missing it.

Thanks for the explanation, I'll add it to the gshell sources too.

> Also, just noticed today that the gsh scripts don't use the setenv/ 
> setjavaenv support that geronimo/client scripts use, so I'll be  
> looking to add that next, so all of the scripts use the same  
> starting environment settings....

I don't think we really want to do that... as it add more platform  
specific muck to the scripts.  It is more desirable to have users  
configure GShell (ala the rc.d bits) to set up any environment  
specific bits.

--jason


>
>
> -Donald
>
>
> Jason Dillon wrote:
>> What is this change for?
>>> Modified: geronimo/server/branches/2.1/assemblies/geronimo- 
>>> boilerplate-minimal/src/main/underlay/bin/gsh.bat
>>> URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.1/assemblies/geronimo-boilerplate-minimal/src/main/underlay/bin/gsh.bat?rev=641813&r1=641812&r2=641813&view=diff

>>>  <http://svn.apache.org/viewvc/geronimo/server/branches/2.1/assemblies/geronimo-boilerplate-minimal/src/main/underlay/bin/gsh.bat?rev=641813&r1=641812&r2=641813&view=diff

>>> >
>>> = 
>>> = 
>>> = 
>>> = 
>>> = 
>>> = 
>>> = 
>>> = 
>>> = 
>>> = 
>>> ====================================================================
>>> --- geronimo/server/branches/2.1/assemblies/geronimo-boilerplate- 
>>> minimal/src/main/underlay/bin/gsh.bat (original)
>>> +++ geronimo/server/branches/2.1/assemblies/geronimo-boilerplate- 
>>> minimal/src/main/underlay/bin/gsh.bat Thu Mar 27 06:45:31 2008
>>> @@ -22,7 +22,8 @@
>>> rem $Rev$ $Date$
>>> rem
>>> -if "%OS%"=="Windows_NT" setlocal
>>> +if "%OS%"=="Windows_NT" setlocal enableextensions
>>> +set ERRORLEVEL=0
>>>
>>> :begin
>> --jason


Mime
View raw message