Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Received-SPF: pass (athena.apache.org: domain of rickmcg@gmail.com designates
 72.14.220.154 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:reply-to:user-agent:mime-version:to:subject:references:in-reply-to:content-type:content-transfer-encoding;
        b=uIWQkPJKlsUHMC85It3xODYaM1lHO7/NUxc0WUIdTDhImyVkQ7EXqjsd8WEHkVIGGKS0ef3tu91SIq2KZhcF8a1M+ntw86qUTTGtuR/21qRq7cpwn6l3S1LhhrASvMj5rkeZYCj9oewcEUICRNIowcfgxNplbjviGcDoWK9fTss=
Message-ID: <47B1EF90.1020803@gmail.com>
Date: Tue, 12 Feb 2008 14:12:16 -0500
From: Rick McGuire <rickmcg@gmail.com>
Reply-To: rickmcg@gmail.com
User-Agent: Thunderbird 2.0.0.9 (Windows/20071031)
MIME-Version: 1.0
To: dev@geronimo.apache.org
Subject: Re: [AsyncHttpClient] handling user-supplied request body (and
 content
 type)
References: <99d1baac0802121034i4e2e1b23k59964cb49431c7b3@mail.gmail.com>
In-Reply-To: <99d1baac0802121034i4e2e1b23k59964cb49431c7b3@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Sangjin Lee wrote:
> While looking at an issue related with a form post (GERONIMO-3839), I 
> found an even more glaring issue.  Namely, any caller-supplied request 
> body is ignored by HttpRequestEncoder.  For example, you may want to 
> do a simple file upload using an octet stream.  One can set the 
> content using HttpMessage.addContent(byte[]).
I sort of wondered about that hard-coded content type when I was working 
on the header changes.  I'm glad it bothered somebody else enough to 
investigate.

Rick

>
> However, HttpRequestEncoder makes a specific assumption that all post 
> requests are form posts.  Therefore, it ignores any message body, and 
> simply encodes the form into the body.  We need to be able to handle 
> this properly.  I'll file a bug shortly...
>
> Thanks,
> Sangjin
>