Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Message-ID: <30468282.1203061630400.JavaMail.jira@brutus>
Date: Thu, 14 Feb 2008 23:47:10 -0800 (PST)
From: "Sangjin Lee (JIRA)" <jira@apache.org>
To: dev@geronimo.apache.org
Subject: [jira] Commented: (GERONIMO-3857) response header parsing is done
 incorrectly
In-Reply-To: <3922744.1203060547977.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/GERONIMO-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569195#action_12569195 ] 

Sangjin Lee commented on GERONIMO-3857:
---------------------------------------

There is also an issue of handling folded headers.  Namely if a CRLF is followed by a LWSP character (SPACE or HTAB), it should be considered a continuation of the previous header line.

HttpResponseDecoder does not handle that case correctly, as it relies solely on CRLF to determine line boundaries.  It would not be able to handle folded headers.  I will follow up with a separate bug on that issue.  I think it can be handled with a separate fix...

> response header parsing is done incorrectly
> -------------------------------------------
>
>                 Key: GERONIMO-3857
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3857
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: AsyncHttpClient
>    Affects Versions: 1.x
>            Reporter: Sangjin Lee
>            Assignee: Rick McGuire
>         Attachments: GERONIMO-3857.patch
>
>
> When we decode response headers, HttpDecoder separates name from value using ": " (note the *single*space after the colon).  This is incorrect.  The HTTP spec says
> - The field value MAY be preceded by any amount of LWS, though a single SP is preferred.
> The separator pattern should be simply ":".  Then any preceding or trailing LWSP characters (SP or HT) should be removed from the value.  This is a rather critical issue.  I had headers like 
> Server: Foo
> Content-Length:62
> Connection: close
> (notice lack of space after "Content-Length:")
> HttpResponseDecoder cannot properly parse the above headers, and throws a StringIndexOutOfBoundsException.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.