geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick McGuire (JIRA)" <j...@apache.org>
Subject [jira] Commented: (GERONIMO-3857) response header parsing is done incorrectly
Date Fri, 15 Feb 2008 10:31:07 GMT

    [ https://issues.apache.org/jira/browse/GERONIMO-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569226#action_12569226
] 

Rick McGuire commented on GERONIMO-3857:
----------------------------------------

I wonder if it would be acceptable for AHC to have a dependency on the javamail API?  The
API has an InternetHeader class that handles header parsing, including the folding issues.


> response header parsing is done incorrectly
> -------------------------------------------
>
>                 Key: GERONIMO-3857
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3857
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: AsyncHttpClient
>    Affects Versions: 1.x
>            Reporter: Sangjin Lee
>            Assignee: Rick McGuire
>         Attachments: GERONIMO-3857.patch
>
>
> When we decode response headers, HttpDecoder separates name from value using ": " (note
the *single*space after the colon).  This is incorrect.  The HTTP spec says
> - The field value MAY be preceded by any amount of LWS, though a single SP is preferred.
> The separator pattern should be simply ":".  Then any preceding or trailing LWSP characters
(SP or HT) should be removed from the value.  This is a rather critical issue.  I had headers
like 
> Server: Foo
> Content-Length:62
> Connection: close
> (notice lack of space after "Content-Length:")
> HttpResponseDecoder cannot properly parse the above headers, and throws a StringIndexOutOfBoundsException.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message