geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sangjin Lee (JIRA)" <>
Subject [jira] Updated: (GERONIMO-3860) HttpResponseDecoder does not handle folded headers properly
Date Thu, 21 Feb 2008 01:53:43 GMT


Sangjin Lee updated GERONIMO-3860:

    Attachment: GERONIMO-3860.patch

I'm attaching a suggested fix for this.

I've added a different method for decoding folded header lines to HttpDecoder.  It properly
takes into account CRLF followed by (SP|HT) and continues if that combination is encountered.
 Later CRLF is removed when the name and value are parsed.

> HttpResponseDecoder does not handle folded headers properly
> -----------------------------------------------------------
>                 Key: GERONIMO-3860
>                 URL:
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: AsyncHttpClient
>    Affects Versions: 1.x
>            Reporter: Sangjin Lee
>            Assignee: Rick McGuire
>            Priority: Minor
>         Attachments: GERONIMO-3860.patch
> HttpResponseDecoder makes an assumption that headers complete in a single line ended
by CRLF.  The HTTP RFC (along with RFC 822) permits a single header spanning multiple lines.
 Such folding can be detected by detecting the leading LWSP char (either a space or a horizontal
> HttpResponseDecoder needs to handle this properly.  Currently it throws a ProtocolDecoderException
(StringIndexOutOfBoundsException underneath).

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message