geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Jencks (JIRA)" <j...@apache.org>
Subject [jira] Closed: (GERONIMO-2204) ProxyMethodInterceptor doesn't handle finalize appropriately
Date Fri, 01 Feb 2008 00:09:08 GMT

     [ https://issues.apache.org/jira/browse/GERONIMO-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

David Jencks closed GERONIMO-2204.
----------------------------------

    Resolution: Won't Fix

We turned off proxies in the server so there isnt much reason to work on this any more.

> ProxyMethodInterceptor doesn't handle finalize appropriately
> ------------------------------------------------------------
>
>                 Key: GERONIMO-2204
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-2204
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: kernel
>    Affects Versions: 1.1, 1.1.1, 1.1.2, 1.1.x, 1.2
>            Reporter: David Jencks
>            Assignee: David Jencks
>            Priority: Minor
>             Fix For: Wish List
>
>
> A user noticed that while debugging in eclipse (or idea with break-on-exceptions turned
on) this method from ProxyMethodInterceptor throws UnsupportedOperationException when finalize
is called on a proxy object:
>     public final Object intercept(final Object object, final Method method, final Object[]
args, final MethodProxy proxy) throws Throwable {
>         ProxyInvoker gbeanInvoker;
>         int interfaceIndex = proxy.getSuperIndex();
>         synchronized (this) {
>             if (gbeanInvokers == null) {
>                 throw new DeadProxyException("Proxy is no longer valid");
>             }
>             gbeanInvoker = gbeanInvokers[interfaceIndex];
>         }
>         if (gbeanInvoker == null) {
>             throw new UnsupportedOperationException("No implementation method: objectName="
+ abstractName + ", method=" + method);
>         }
>         return gbeanInvoker.invoke(abstractName, args);
>     }
> This appears to be harmless since the proxy doesn't implement finalize, but annoying.
 We could fix this by explicitly ignoring the finalize method in the code above, possibly
by installing a suitable FinalizeInvoker, or by using a CallbackFilter with  a Noop or SerizializableNoop
callback (the strategy used by spring aop).
> Is this worth fixing? Which way would be best? 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message