Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 33776 invoked from network); 24 Dec 2007 22:39:05 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 24 Dec 2007 22:39:05 -0000 Received: (qmail 48333 invoked by uid 500); 24 Dec 2007 22:38:53 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 48287 invoked by uid 500); 24 Dec 2007 22:38:53 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 48276 invoked by uid 99); 24 Dec 2007 22:38:53 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Dec 2007 14:38:53 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Dec 2007 22:38:39 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 45744714231 for ; Mon, 24 Dec 2007 14:38:43 -0800 (PST) Message-ID: <3383473.1198535923281.JavaMail.jira@brutus> Date: Mon, 24 Dec 2007 14:38:43 -0800 (PST) From: "solprovider (JIRA)" To: dev@geronimo.apache.org Subject: [jira] Commented: (GERONIMO-3243) ActiveMQ violates System Properties In-Reply-To: <22303596.1181756186950.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/GERONIMO-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554313 ] solprovider commented on GERONIMO-3243: --------------------------------------- ActiveMQ-5.0 0 was released 20071213. Should Geronimo immediately upgrade ActiveMQ? > ActiveMQ violates System Properties > ----------------------------------- > > Key: GERONIMO-3243 > URL: https://issues.apache.org/jira/browse/GERONIMO-3243 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: ActiveMQ > Affects Versions: 2.0.1, 2.0.2 > Reporter: solprovider > Priority: Blocker > Fix For: 2.1 > > > The latest Geronimo 1.2 and 2.0 use ActiveMQ. (Would someone familiar with Geronimo development please add all affected versions?) > ActiveMQ adds a HashMap as a global Property named "org.apache.activeio.journal.active.lockMap". > Properties must use Strings for keys and values per http://java.sun.com/j2se/1.4.2/docs/api/java/util/Properties.html > This causes any code reading all the Properties and expecting Strings to error. > {code:title=Test Code|borderStyle=solid} > boolean test(){ //true = passes, false = failed. > boolean test = true; > java.util.Properties properties = System.getProperties(); > java.util.Enumeration enumeration = properties.elements(); > while(test & enumeration.hasMoreElements()) test= String.class.equals(enumeration.nextElement().getClass()); > enumeration = properties.keys(); > while(test & enumeration.hasMoreElements()) test= String.class.equals(enumeration.nextElement().getClass()); > return test; > } > {code} > The permanent fix is for Geronimo to update to a better version of ActiveMQ, either downgrading to before the bug was programmed or wait for the ActiveMQ team to follow the standards. That is unlikely to be tested and released quickly. > The quick fix is to disable the offensive code. For Geronimo 1.2 on Windows, add this line at the beginning of STARTUP.BAT: > SET GERONIMO_OPTS=-Dorg.apache.activeio.journal.active.DisableLocking=true %GERONIMO_OPTS% > David Jencks suggested that Geronimo can set the org.apache.activeio.journal.active.DisableLocking property in a Geronimo SystemProperties gbean, there's one called ServerSystemProperties in j2ee-server. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.