Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 13712 invoked from network); 22 Dec 2007 00:47:07 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 22 Dec 2007 00:47:07 -0000 Received: (qmail 46548 invoked by uid 500); 22 Dec 2007 00:46:55 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 46512 invoked by uid 500); 22 Dec 2007 00:46:55 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 46500 invoked by uid 99); 22 Dec 2007 00:46:55 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Dec 2007 16:46:55 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Dec 2007 00:46:51 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 439A1714159 for ; Fri, 21 Dec 2007 16:46:43 -0800 (PST) Message-ID: <32399358.1198284403274.JavaMail.jira@brutus> Date: Fri, 21 Dec 2007 16:46:43 -0800 (PST) From: "Viet Hung Nguyen (JIRA)" To: dev@geronimo.apache.org Subject: [jira] Updated: (GERONIMO-3714) Monitoring console does no error checking on add/edit graph timeframe In-Reply-To: <30810590.1198102183259.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/GERONIMO-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viet Hung Nguyen updated GERONIMO-3714: --------------------------------------- Attachment: geronimo-3714.patch I forgot to add the JS checks to ensure that the user cannot specify anything less than 2*(snapshot_duration) for the graph's time window. So I have added that stuff in this new patch > Monitoring console does no error checking on add/edit graph timeframe > --------------------------------------------------------------------- > > Key: GERONIMO-3714 > URL: https://issues.apache.org/jira/browse/GERONIMO-3714 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: monitoring > Affects Versions: 2.1 > Reporter: Erik B. Craig > Assignee: Viet Hung Nguyen > Attachments: geronimo-3714.patch > > > Currently the Monitoring console does no error checking on add/edit graph timeframe, it is therefore possible to define graphs that will break the page. > There should be javascript checks to prevent the user from entering values anything less than 3*(snapshot duration) and anything more than the archive cutoff point, UNLESS 'show archive' is checked -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.