Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 22784 invoked from network); 7 Dec 2007 09:46:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 7 Dec 2007 09:46:08 -0000 Received: (qmail 17001 invoked by uid 500); 7 Dec 2007 09:45:55 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 16953 invoked by uid 500); 7 Dec 2007 09:45:55 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 16942 invoked by uid 99); 7 Dec 2007 09:45:55 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Dec 2007 01:45:55 -0800 X-ASF-Spam-Status: No, hits=-98.0 required=10.0 tests=ALL_TRUSTED,GAPPY_SUBJECT X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Dec 2007 09:46:04 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 76ECD71425B for ; Fri, 7 Dec 2007 01:45:43 -0800 (PST) Message-ID: <25958461.1197020743484.JavaMail.jira@brutus> Date: Fri, 7 Dec 2007 01:45:43 -0800 (PST) From: "Vamsavardhana Reddy (JIRA)" To: dev@geronimo.apache.org Subject: [jira] Commented: (GERONIMO-3654) Moving o.a.g.s.jaas.NamedUPCredentailLoginModule to o.a.g.s.realm.providers In-Reply-To: <9234511.1196406643551.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/GERONIMO-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549353 ] Vamsavardhana Reddy commented on GERONIMO-3654: ----------------------------------------------- On the second thought, I am planning to skip step 2 from the above. I will mark org.apache.geronimo.jaas.NamedUPCredentialLoginModule as deprecated only. We can remove the class from the codebase after the next release. > Moving o.a.g.s.jaas.NamedUPCredentailLoginModule to o.a.g.s.realm.providers > --------------------------------------------------------------------------- > > Key: GERONIMO-3654 > URL: https://issues.apache.org/jira/browse/GERONIMO-3654 > Project: Geronimo > Issue Type: Task > Security Level: public(Regular issues) > Components: security > Affects Versions: 2.0.x, 2.1 > Reporter: Vamsavardhana Reddy > Assignee: Vamsavardhana Reddy > Fix For: 2.0.x, 2.1 > > > David Jencks suggested that we move org.apache.geronmio.security.jaas.NamedUPCredentailLoginModule to org.apache.geronimo.security.realm.providers package. I intend to do the following. > 1. svn copy org.apache.geronmio.security.jaas.NamedUPCredentailLoginModule to org.apache.geronimo.security.realm.providers.NamedUPCredentailLoginModule > 2. Make org.apache.geronmio.security.jaas.NamedUPCredentailLoginModule extend org.apache.geronimo.security.realm.providers.NamedUPCredentailLoginModule. > 3. Mark org.apache.geronmio.security.jaas.NamedUPCredentailLoginModule as deprecated. > 4. Change all references from org.apache.geronmio.security.jaas.NamedUPCredentailLoginModule to org.apache.geronimo.security.realm.providers.NamedUPCredentailLoginModule > Does anyone see this coming in the way of compatibility? I do not intend to change the option name "org.apache.geronimo.jaas.NamedUPCredentialLoginModule.Name" as this will surely break compatibility. Whether or not the move breaks compatibility, should we consider this move only in trunk and not in branches\2.0? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.