geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Jencks (JIRA)" <j...@apache.org>
Subject [jira] Closed: (GERONIMO-2516) MCFConnectionInterceptor is calling destroy() in connectionClosed()
Date Sun, 23 Dec 2007 07:24:43 GMT

     [ https://issues.apache.org/jira/browse/GERONIMO-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

David Jencks closed GERONIMO-2516.
----------------------------------

    Resolution: Invalid

I think this was a misunderstanding of the architecture.  BTW, the match method is called
from Pool classes such as SinglePoolConnectionInterceptor.

> MCFConnectionInterceptor is calling destroy() in connectionClosed()
> -------------------------------------------------------------------
>
>                 Key: GERONIMO-2516
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-2516
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: connector
>    Affects Versions: 1.1
>         Environment: Windows XP, Eclipse 3.2.1, WTP 1.5, Geronimo 1.1
>            Reporter: Romano Silva
>
> MCFConnectionInterceptor is calling destroy() in connectionClosed() while it shouldn't.
Actually, it's not checking the connectionReturnAction argument..
> I would change returnConnection to:
> public void returnConnection(
>             ConnectionInfo connectionInfo,
>             ConnectionReturnAction connectionReturnAction) {
>         ManagedConnectionInfo mci = connectionInfo.getManagedConnectionInfo();
>         ManagedConnection mc = mci.getManagedConnection();
>         try {
>             if (connectionReturnAction == ConnectionReturnAction.DESTROY)
>             {
>                 mc.destroy();
>             }
>         } catch (ResourceException e) {
>             //log and forget
>         } catch (Error e) {
>             throw e;
>         } catch (Throwable t) {
>             //log and forget
>         }
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message