From dev-return-56593-apmail-geronimo-dev-archive=geronimo.apache.org@geronimo.apache.org Wed Nov 07 22:42:59 2007 Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 38440 invoked from network); 7 Nov 2007 22:42:59 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 7 Nov 2007 22:42:59 -0000 Received: (qmail 30288 invoked by uid 500); 7 Nov 2007 22:42:44 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 30243 invoked by uid 500); 7 Nov 2007 22:42:44 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 30232 invoked by uid 99); 7 Nov 2007 22:42:44 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Nov 2007 14:42:44 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [69.147.95.72] (HELO smtp109.plus.mail.sp1.yahoo.com) (69.147.95.72) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 07 Nov 2007 22:42:47 +0000 Received: (qmail 57122 invoked from network); 7 Nov 2007 22:42:26 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Received:X-YMail-OSG:Mime-Version:Content-Transfer-Encoding:Message-Id:Content-Type:To:From:Subject:Date:X-Mailer; b=Zp6r2Iq3fHykQXreCpHJO31OjyKeHBtHG0Hdh/uT+cnHZ73aqZz/lUhYJNW0+TzUMZBTVSi/f3aurs3IsRSSGuEXRVZLkOnk26C9xNkPX4eWyWQES8c2NIyP/zgbeZZGpow6nysArZoD9qyf5kn2LJjwsNMci9SDv35m2+Jmrqw= ; Received: from unknown (HELO ?192.168.1.101?) (david_jencks@67.102.173.8 with plain) by smtp109.plus.mail.sp1.yahoo.com with SMTP; 7 Nov 2007 22:42:26 -0000 X-YMail-OSG: yNiJBPgVM1mtYLJTag9vRZSIKHzUWFCbB7ml7F4qJ8eiByQCd0cPe2rEVfviON4w7pQ.ODz64PeleckP_ALxp76SmcGjnLgp_sXN_l_KqEfTGFBziTDJEKS5.J.k Mime-Version: 1.0 (Apple Message framework v752.3) Content-Transfer-Encoding: 7bit Message-Id: <9B7B4965-7867-48E4-86D0-15E0F745684C@yahoo.com> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed To: "Geronimo Dev List (JIRA)" From: David Jencks Subject: Can we deal generically with container specific jsr77 statistics? Date: Wed, 7 Nov 2007 14:42:07 -0800 X-Mailer: Apple Mail (2.752.3) X-Virus-Checked: Checked by ClamAV on apache.org There's been some discussion on https://issues.apache.org/jira/browse/ GERONIMO-3586 and https://issues.apache.org/jira/browse/GERONIMO-3587 about how to deal with the jetty and tomcat jsr77 statistics. It might be good to try to have such discussions on the dev list... I talked with Viet about this on IRC for a while and have an idea to suggest that might keep the container specific code in the containers and allow management code to avoid needing any container specific classes. According to my IDEA project setup and Viet, the container specific interfaces and implementations are only used inside the jetty and tomcat containers to make it easier for the container to update the statistics. They are not used in the monitoring plugin. IIUC the problems start when you try to send e.g. a JettyWebConnectorStatsImpl over the wire to a monitoring app, and the object can't be deserialized. I suggest we have in geronimo-management a StatsImpl class similar to the existing one but taking the name-statistic map in its constructor and being immutable. Then the jetty/tomcat specific stats classes won't implement Stats at all but just the container specific method. Instead of extending StatsImpl they will delegate to an instance they create in their constructor. The MEJB can return the delegate StatsImpl objects, thus avoiding any need for any container specific classes, and the container specific adapters can be in with the containers. Comments? thanks david jencks