From dev-return-57190-apmail-geronimo-dev-archive=geronimo.apache.org@geronimo.apache.org Wed Nov 28 20:36:13 2007 Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 85733 invoked from network); 28 Nov 2007 20:36:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 28 Nov 2007 20:36:13 -0000 Received: (qmail 95570 invoked by uid 500); 28 Nov 2007 20:35:59 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 95511 invoked by uid 500); 28 Nov 2007 20:35:59 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 95500 invoked by uid 99); 28 Nov 2007 20:35:59 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Nov 2007 12:35:59 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Nov 2007 20:35:48 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 4A38C714240 for ; Wed, 28 Nov 2007 12:35:45 -0800 (PST) Message-ID: <17504936.1196282145301.JavaMail.jira@brutus> Date: Wed, 28 Nov 2007 12:35:45 -0800 (PST) From: "David Jencks (JIRA)" To: dev@geronimo.apache.org Subject: [jira] Commented: (GERONIMO-3641) NamedUPCredentialLoginModule vs ConfiguredIdentityNamedUsernamePasswordLoginModule In-Reply-To: <15399889.1196250043899.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/GERONIMO-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546376 ] David Jencks commented on GERONIMO-3641: ---------------------------------------- ConfiguredIdentityNamedUsernamePasswordLoginModule is pretty much essential for the TCK. You use it in case you want to supply credentials for the server when its calling another server, e.g. a remote web service and you are relying on the server credentials rather than the user credentials. You can get a similar effect with a run-as where the run-as subject has been set up with NamedUPCredentialLoginModule but using ConfiguredIdentityNamedUsernamePasswordLoginModule means you can avoid the run-as. > NamedUPCredentialLoginModule vs ConfiguredIdentityNamedUsernamePasswordLoginModule > ---------------------------------------------------------------------------------- > > Key: GERONIMO-3641 > URL: https://issues.apache.org/jira/browse/GERONIMO-3641 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: security > Affects Versions: 2.0.x, 2.1 > Reporter: Vamsavardhana Reddy > Fix For: 2.0.x, 2.1 > > > I see that ConfiguredIdentityNamedUsernamePasswordLoginModule and NamedUPCredentialLoginModule are added to geronimo codebase around the same time (rev 159325 and rev 159560). The difference between the two is that NamedUPCredentialLoginModule uses the user supplied username and password where as ConfiguredIdentityNamedUsernamePasswordLoginModule gets the username and password from options supplied to the login module. NamedUPCredentialLoginModule is used by the Security realms portlet whereas there are no references to ConfiguredIdentityNamedUsernamePasswordLoginModule in the codebase. I guess one of them (most likely ConfiguredIdentityNamedUsernamePasswordLoginModule) is redundant and it should be eliminated. What am I missing? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.