geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guillaume Nodet" <gno...@gmail.com>
Subject Re: [GShell] Plexus dependency in CommandLineBuilder
Date Thu, 11 Oct 2007 18:50:43 GMT
FYI, I've found a workaround as Spring can solve such situations if
using property injection rather than constructor injection... So
creating wrapper solves the problem.

On 10/11/07, Guillaume Nodet <gnodet@gmail.com> wrote:
> Ok, so it seems that wiring gshell using spring is not too difficult.
> However I have seen a weird dependency between two POJOs which cause a
> problem when wiring them.   It happens between DefaultCommandExecutor
> which has a dependency on OsgiCommandLineBuilder which also has a
> dependency on the command executor.  Is there any way to refactor
> things a bit to avoid this circular dependency ?
>
> On 10/11/07, Jason Dillon <jason@planet57.com> wrote:
> > Yup, sounds fine.  As I mentioned to ya a while ago on IRC I took a
> > few short cuts when I whipped this stuff up... after what now seems
> > like a long time ago.
> >
> > Anyways, go for it.  Only comment I've got is you should call the
> > intf CommandLineBuilder and the default impl
> > DefaultCommandLineBuilder (prefix insteand of suffix to follow how
> > the other components play... ).
> >
> > --jason
> >
> >
> > On Oct 11, 2007, at 6:46 AM, Guillaume Nodet wrote:
> >
> > > I'm trying to configure GShell through spring because spring can
> > > integrate nicely in OSGi (which is my main purpose) and I just crossed
> > > one problem:  the CommandLineBuilder is a dependency of
> > > DefaultCommandExecutor (in terms of POJOs).  The problem is that
> > > CommandLineBuilder is a class, not an interface, with a strong
> > > dependency on plexus.  So I'd like to introduce an interface
> > > CommandLineBuilder and rename the class as the default implementation
> > > CommandLineBuilderDefault.  Any objections ?
> > >
> > > --
> > > Cheers,
> > > Guillaume Nodet
> > > ------------------------
> > > Blog: http://gnodet.blogspot.com/
> >
> >
>
>
> --
> Cheers,
> Guillaume Nodet
> ------------------------
> Blog: http://gnodet.blogspot.com/
>


-- 
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/

Mime
View raw message