Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Message-ID: <46B61DC7.6010400@apache.org>
Date: Sun, 05 Aug 2007 14:58:15 -0400
From: Donald Woods <dwoods@apache.org>
Reply-To: dwoods@apache.org
User-Agent: Thunderbird 1.5.0.12 (Windows/20070509)
MIME-Version: 1.0
To: dev@geronimo.apache.org
Subject: Re: svn commit: r562816 -
 /geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java
References: <20070805040339.34CC31A981A@eris.apache.org>
In-Reply-To: <20070805040339.34CC31A981A@eris.apache.org>
Content-Type: multipart/signed; protocol="application/x-pkcs7-signature";
 micalg=sha1; boundary="------------ms080907010703050802040600"

This is a cryptographically signed message in MIME format.

--------------ms080907010703050802040600
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Are you going to include this in branches/2.0 for a 2.0.1 release?

-Donald

linsun@apache.org wrote:
> Author: linsun
> Date: Sat Aug  4 21:03:38 2007
> New Revision: 562816
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=562816
> Log:
> oops missed two spots on formatting
> 
> Modified:
>     geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java
> 
> Modified: geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java?view=diff&rev=562816&r1=562815&r2=562816
> ==============================================================================
> --- geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java (original)
> +++ geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/BaseDeploymentFactory.java Sat Aug  4 21:03:38 2007
> @@ -70,8 +70,9 @@
>  
>      private ConnectParams parseURI(String uri) {
>          uri = uri.trim();
> -        if (log.isDebugEnabled())
> +        if (log.isDebugEnabled()) {
>              log.debug("Parsing URI=" + uri);
> +        }
>          if(!uri.startsWith(URI_PREFIX)) {
>              return null;
>          }
> @@ -127,8 +128,9 @@
>          if (params == null) {
>              return null;
>          }
> -        if (log.isDebugEnabled())
> +        if (log.isDebugEnabled()) {
>              log.debug("Using protocol=" + params.getProtocol() + ", host=" + params.getHost() + ", port=" + params.getPort());
> +        }
>  
>          try {
>              if (params.getProtocol().equals("jmx")) {
> 
> 
> 
> 

--------------ms080907010703050802040600
Content-Type: application/x-pkcs7-signature; name="smime.p7s"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="smime.p7s"
Content-Description: S/MIME Cryptographic Signature

MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIJAzCC
AtwwggJFoAMCAQICEGl0fFJRFoUogDNHr2j130gwDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UE
BhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMT
I1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA3MDQwMzE5MDgwOFoX
DTA4MDQwMjE5MDgwOFowQzEfMB0GA1UEAxMWVGhhd3RlIEZyZWVtYWlsIE1lbWJlcjEgMB4G
CSqGSIb3DQEJARYRZHdvb2RzQGFwYWNoZS5vcmcwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAw
ggEKAoIBAQDENBaTcon2Q3/v2plog9ympNR5IWM94JDvXhWanc1Qz07/sIerwI99WZ4z0AAV
wBelazRFCsXkFCaNDM1sOJ0gx4I+KISb5XoX/omAhYIs+Cwac2hitDraZE2Q7x281nLn4TPR
d29GVpUZVKsaDvmvnDAagGTEkOfHBx/yUihzshJn4S6n6vahimEWWXn5Qw4Oj5Muvz8iKGoA
MilrHZrfSKvCqT0LhGaFnZhrMvqeCguf0/IlP6YJ2kBmouV3XHFUaiai4PQZ7ahtbW7meKb4
b25QUjIFJHIr0KhJXqoGADRAlBgTaqWBIKbdTmYBsr55aasjp5TU+XAxiqFr1FoTAgMBAAGj
LjAsMBwGA1UdEQQVMBOBEWR3b29kc0BhcGFjaGUub3JnMAwGA1UdEwEB/wQCMAAwDQYJKoZI
hvcNAQEFBQADgYEAJReGzfwY5+BY6PuXJQLURKni6kBaFi7Z7b+tjn6iTdlZhbSF9YHazHIJ
9J6oaOzfG28JroaAlk9PeAvbC38f2kaU4bWQgm6yp6308ZRyM8V3CHXe6Wm9bXiJeZCRTpix
Mvxo+mWG2Jq0vnfjWxt+Fbi0ic1xl3I+1UguMfAfAggwggLcMIICRaADAgECAhBpdHxSURaF
KIAzR69o9d9IMA0GCSqGSIb3DQEBBQUAMGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3
dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJl
ZW1haWwgSXNzdWluZyBDQTAeFw0wNzA0MDMxOTA4MDhaFw0wODA0MDIxOTA4MDhaMEMxHzAd
BgNVBAMTFlRoYXd0ZSBGcmVlbWFpbCBNZW1iZXIxIDAeBgkqhkiG9w0BCQEWEWR3b29kc0Bh
cGFjaGUub3JnMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAxDQWk3KJ9kN/79qZ
aIPcpqTUeSFjPeCQ714Vmp3NUM9O/7CHq8CPfVmeM9AAFcAXpWs0RQrF5BQmjQzNbDidIMeC
PiiEm+V6F/6JgIWCLPgsGnNoYrQ62mRNkO8dvNZy5+Ez0XdvRlaVGVSrGg75r5wwGoBkxJDn
xwcf8lIoc7ISZ+Eup+r2oYphFll5+UMODo+TLr8/IihqADIpax2a30irwqk9C4RmhZ2YazL6
ngoLn9PyJT+mCdpAZqLld1xxVGomouD0Ge2obW1u5nim+G9uUFIyBSRyK9CoSV6qBgA0QJQY
E2qlgSCm3U5mAbK+eWmrI6eU1PlwMYqha9RaEwIDAQABoy4wLDAcBgNVHREEFTATgRFkd29v
ZHNAYXBhY2hlLm9yZzAMBgNVHRMBAf8EAjAAMA0GCSqGSIb3DQEBBQUAA4GBACUXhs38GOfg
WOj7lyUC1ESp4upAWhYu2e2/rY5+ok3ZWYW0hfWB2sxyCfSeqGjs3xtvCa6GgJZPT3gL2wt/
H9pGlOG1kIJusqet9PGUcjPFdwh13ulpvW14iXmQkU6YsTL8aPplhtiatL5341sbfhW4tInN
cZdyPtVILjHwHwIIMIIDPzCCAqigAwIBAgIBDTANBgkqhkiG9w0BAQUFADCB0TELMAkGA1UE
BhMCWkExFTATBgNVBAgTDFdlc3Rlcm4gQ2FwZTESMBAGA1UEBxMJQ2FwZSBUb3duMRowGAYD
VQQKExFUaGF3dGUgQ29uc3VsdGluZzEoMCYGA1UECxMfQ2VydGlmaWNhdGlvbiBTZXJ2aWNl
cyBEaXZpc2lvbjEkMCIGA1UEAxMbVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIENBMSswKQYJ
KoZIhvcNAQkBFhxwZXJzb25hbC1mcmVlbWFpbEB0aGF3dGUuY29tMB4XDTAzMDcxNzAwMDAw
MFoXDTEzMDcxNjIzNTk1OVowYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25z
dWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJ
c3N1aW5nIENBMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDEpjxVc1X7TrnKmVoeaMB1
BHCd3+n/ox7svc31W/Iadr1/DDph8r9RzgHU5VAKMNcCY1osiRVwjt3J8CuFWqo/cVbLrzwL
B+fxH5E2JCoTzyvV84J3PQO+K/67GD4Hv0CAAmTXp6a7n2XRxSpUhQ9IBH+nttE8YQRAHmQZ
cmC3+wIDAQABo4GUMIGRMBIGA1UdEwEB/wQIMAYBAf8CAQAwQwYDVR0fBDwwOjA4oDagNIYy
aHR0cDovL2NybC50aGF3dGUuY29tL1RoYXd0ZVBlcnNvbmFsRnJlZW1haWxDQS5jcmwwCwYD
VR0PBAQDAgEGMCkGA1UdEQQiMCCkHjAcMRowGAYDVQQDExFQcml2YXRlTGFiZWwyLTEzODAN
BgkqhkiG9w0BAQUFAAOBgQBIjNFQg+oLLswNo2asZw9/r6y+whehQ5aUnX9MIbj4Nh+qLZ82
L8D0HFAgk3A8/a3hYWLD2ToZfoSxmRsAxRoLgnSeJVCUYsfbJ3FXJY3dqZw5jowgT2Vfldr3
94fWxghOrvbqNOUQGls1TXfjViF4gtwhGTXeJLHTHUb/XV9lTzGCA2QwggNgAgEBMHYwYjEL
MAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAq
BgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhBpdHxSURaFKIAz
R69o9d9IMAkGBSsOAwIaBQCgggHDMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZI
hvcNAQkFMQ8XDTA3MDgwNTE4NTgxNVowIwYJKoZIhvcNAQkEMRYEFJlNc2Bsu2IMGUbEAnGA
ZuJqzMFdMFIGCSqGSIb3DQEJDzFFMEMwCgYIKoZIhvcNAwcwDgYIKoZIhvcNAwICAgCAMA0G
CCqGSIb3DQMCAgFAMAcGBSsOAwIHMA0GCCqGSIb3DQMCAgEoMIGFBgkrBgEEAYI3EAQxeDB2
MGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQu
MSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgSXNzdWluZyBDQQIQaXR8UlEW
hSiAM0evaPXfSDCBhwYLKoZIhvcNAQkQAgsxeKB2MGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQK
ExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVyc29u
YWwgRnJlZW1haWwgSXNzdWluZyBDQQIQaXR8UlEWhSiAM0evaPXfSDANBgkqhkiG9w0BAQEF
AASCAQAGtmnIwXcr0P/9rZtJxREbMcdQOtN1Kyse6J9VIDr5FoZ4pAjMLScRPPDaHOAOVeLP
0SBNB8IQn0Uf0iyZw1j+zyycsSkJl25ZqzrBLgd7d6LspkPgYh1c5QsAwjbL3WVLYlxIadWP
3Noo/DOCKHWyQxSyRW9QazCe45HN0/bioJ7Oc8j73vR4Wu9ZXKXL/vRZVpYTEV4xtH2mnwqu
WiWrj+62F9Rimff+Khc9wk5Yl4HDcVRF3mMkPLImtBIXCUCwU2kOZK2lEfUhChu3jWxPaqD5
EFjtWPANIJZ6ULZPito6LaUKEjGqIEGN0FljXOkoW11Txg9+V+nPjxyGLdcBAAAAAAAA
--------------ms080907010703050802040600--