Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 46851 invoked from network); 23 Jul 2007 21:57:35 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 23 Jul 2007 21:57:35 -0000 Received: (qmail 29296 invoked by uid 500); 23 Jul 2007 21:57:34 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 29251 invoked by uid 500); 23 Jul 2007 21:57:34 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 29240 invoked by uid 99); 23 Jul 2007 21:57:34 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Jul 2007 14:57:34 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [69.147.95.91] (HELO smtp128.plus.mail.sp1.yahoo.com) (69.147.95.91) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 23 Jul 2007 14:57:32 -0700 Received: (qmail 37927 invoked from network); 23 Jul 2007 21:57:11 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Received:X-YMail-OSG:Mime-Version:In-Reply-To:References:Content-Type:Message-Id:Content-Transfer-Encoding:From:Subject:Date:To:X-Mailer; b=K2Cf0LzJEDxejxzDnbj8EEUC1y95A8/h73nRL6ATOb7Vqgnf8kDIBLPs73gTjFGpo2nFqEfuH4vzcHIrbb6eCWIqqsp3KJgTMFuhMgZelPK9YIaUNSO4PQq0mVlvcP2aumQC2Ys2d6+tL7RF4DAm8f7wA6SaQJ6q5VsuT4vGGWw= ; Received: from unknown (HELO ?192.168.1.101?) (david_jencks@67.102.173.8 with plain) by smtp128.plus.mail.sp1.yahoo.com with SMTP; 23 Jul 2007 21:57:11 -0000 X-YMail-OSG: bdBqyUUVM1mjKcJM0i6Lk5UTg.U6KiXK.sXE3Z5oobqegPCL2mtw.iceCEINeamaDHnBRahDpj4HVlb8zmOjhu272AZOpuTC.bo9_aqdLbas7N0lAOMYZ0lBR51S Mime-Version: 1.0 (Apple Message framework v752.3) In-Reply-To: <33EE8153-B08E-4800-BC01-284D28936E1E@hogstrom.org> References: <33EE8153-B08E-4800-BC01-284D28936E1E@hogstrom.org> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <694E5378-3670-4517-8676-79EAA290D054@yahoo.com> Content-Transfer-Encoding: 7bit From: David Jencks Subject: Re: Simpler config-substitutions.properties keys? Date: Mon, 23 Jul 2007 14:57:18 -0700 To: dev@geronimo.apache.org X-Mailer: Apple Mail (2.752.3) X-Virus-Checked: Checked by ClamAV on apache.org I fixed this as part of https://issues.apache.org/jira/browse/GERONIMO-2735 and documented some stuff at http://cwiki.apache.org/confluence/ display/GMOxDOC20/Multiple+Repositories PLEASE NOTE that I added a prefix for command line and system properties that you want to get into the substitution map. By default, you have to prefix substitution properties in the system environment or in system properties with org.apache.geronimo.config.substitution. so that we won't get accidental resetting of our ports or whatever from other programs settings. IIRC (which I may not) I proposed this when the feature was originally discussed and only realized it wasn't implemented when I came to examine the code again. thanks david jencks On Jul 22, 2007, at 3:29 PM, Matt Hogstrom wrote: > go for it > > On Jul 22, 2007, at 1:48 PM, David Jencks wrote: > >> I noticed all the keys (except "portOffset") in config- >> substitions.properties start with "Plan" which seems redundant >> obvious and confusing. >> >> Anyone object if I remove this prefix? >> >> e.g. instead of >> >> PlanServerHostname=0.0.0.0 >> PlanNamingPort=1099 >> PlanOpenEJBPort=4201 >> PlanClientAddresses=127.0.0.1 >> >> ServerHostname=0.0.0.0 >> NamingPort=1099 >> OpenEJBPort=4201 >> ClientAddresses=127.0.0.1 >> >> >> thanks >> david jencks >> >> >