geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevan Miller <kevan.mil...@gmail.com>
Subject Re: [VOTE] Release specs for JACC, JSP, Servlet
Date Tue, 31 Jul 2007 18:49:01 GMT

On Jul 30, 2007, at 10:04 PM, Tim McConnell wrote:

> Hi, Please review and vote on the release of the following Geronimo  
> specs:
>
> -- geronimo-jacc_1.1_spec-1.0
> -- geronimo-jsp_2.1_spec-1.0
> -- geronimo-servlet_2.5_spec-1.1

+1. Looks good. One comment -- I'm not a big fan of the NOTICE file  
contents, however. For example:

// ------------------------------------------------------------------
// NOTICE file corresponding to the section 4d of The Apache License,
// Version 2.0, in this case for Servlet 2.5
// ------------------------------------------------------------------

Servlet 2.5
Copyright 2003-2007 The Apache Software Foundation
...

I think it would be better if it was:

// ------------------------------------------------------------------
// NOTICE file corresponding to the section 4d of The Apache License,
// Version 2.0, in this case for the Apache Geronimo Servlet 2.5  
Specification
// ------------------------------------------------------------------

Apache Geronimo Servlet 2.5 Specification
Copyright 2003-2007 The Apache Software Foundation
...

Not necessary that this be changed, but could be updated, also...

--kevan



Mime
View raw message