Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 94064 invoked from network); 5 Jun 2007 13:51:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 5 Jun 2007 13:51:21 -0000 Received: (qmail 56640 invoked by uid 500); 5 Jun 2007 13:51:22 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 56593 invoked by uid 500); 5 Jun 2007 13:51:22 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 56582 invoked by uid 99); 5 Jun 2007 13:51:22 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jun 2007 06:51:22 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of paulmcmahan@gmail.com designates 66.249.82.224 as permitted sender) Received: from [66.249.82.224] (HELO wx-out-0506.google.com) (66.249.82.224) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jun 2007 06:51:17 -0700 Received: by wx-out-0506.google.com with SMTP id t11so1394754wxc for ; Tue, 05 Jun 2007 06:50:56 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:mime-version:in-reply-to:references:content-type:message-id:content-transfer-encoding:from:subject:date:to:x-mailer; b=lhk/eTMgc2FssAE2zh7XpxLs01FDbs3kYBt6ZeudYkWAMVGB0dKhwSs+cWg+2ct2HyRifQJ/DiX0TqxCd2jY7vfpMRBh2EZEN8Xalftz5cxMe1Vj1GgqQ/7u0CGnB+D99ANljMQ42nbfV05lc01+n8gsZ41qdJlFPdiRn5TfkoY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:mime-version:in-reply-to:references:content-type:message-id:content-transfer-encoding:from:subject:date:to:x-mailer; b=WvmxWjcbijLN6vdTbqheAREKr7QfR+keEtK0jk+syyaEooGTfsHSvszR4EBheQDyyhgcDS3eugKMD7ra79ZsxskNx2Hssinnd0W/4vJqzw0BWxev3ceGPLQFOcz+EIiJ3rgcicDUMiHqvbsZsQ4YfYtlTsyZizdUBsZSZsO595k= Received: by 10.90.118.8 with SMTP id q8mr4847378agc.1181051455882; Tue, 05 Jun 2007 06:50:55 -0700 (PDT) Received: from ?9.37.214.131? ( [129.33.49.251]) by mx.google.com with ESMTP id 13sm1984695wrl.2007.06.05.06.50.54; Tue, 05 Jun 2007 06:50:55 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v752.3) In-Reply-To: References: <20070604204452.0F5D11A981C@eris.apache.org> <7D8A00CA-4678-4CF2-9804-AF977A849BC6@planet57.com> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <6B1A9216-30B8-412F-9062-12919674EBE3@gmail.com> Content-Transfer-Encoding: 7bit From: Paul McMahan Subject: Re: svn commit: r544258 - in /geronimo/server/trunk/applications: console/geronimo-console-framework/ console/geronimo-console-standard/ geronimo-ca-helper/ geronimo-examples/geronimo-jsp-examples/ geronimo-ldap-demo/ geronimo-remote-deploy/ geronimo-uddi-... Date: Tue, 5 Jun 2007 09:51:02 -0400 To: dev@geronimo.apache.org X-Mailer: Apple Mail (2.752.3) X-Virus-Checked: Checked by ClamAV on apache.org I know of four developers that hit the error, but don't understand why everyone didn't hit it. Without the change I see the build error reported in GERONIMO-3209. I think that the previous plugin looked for '' by default and the new one does not. The result is that that placeholder string is left in web.xml which results in a parse error when geronimo tries to deploy it while building the configs. Best wishes, Paul On Jun 5, 2007, at 1:21 AM, Jason Dillon wrote: > From what I could tell, the previous jspc plugin didn't use that > string for a default replace token, instead it used '' if > the injectString was not configured. The new plugin behaves the > same way. > > So... I'm not sure how the previous plugin handles replacing '' with the fragment w/o this configuration. > > What errors does it produce? I ran the build a few times and it > did not produce any errors. > > --jason > > > On Jun 4, 2007, at 7:17 PM, Paul McMahan wrote: > >> GERONIMO-3209 shows a build error that I and two others hit. From >> a brief conversation with Jeff on IRC, it seems that the current >> jspc plugin no longer supports the default placeholder keyword >> used by the geronimo applications: >> >> This commit fixes the build error. >> >> Best wishes, >> Paul >> >> On Jun 4, 2007, at 6:38 PM, Jason Dillon wrote: >> >>> Why is this needed? >>> >>> --jason >>> >>> >>> On Jun 4, 2007, at 1:44 PM, pmcmahan@apache.org wrote: >>> >>>> Author: pmcmahan >>>> Date: Mon Jun 4 13:44:49 2007 >>>> New Revision: 544258 >>>> >>>> URL: http://svn.apache.org/viewvc?view=rev&rev=544258 >>>> Log: >>>> GERONIMO-3209 jspc maven plugin fails in some environments when >>>> the injectString is not explicitly declared >>>> >>>> Modified: >>>> geronimo/server/trunk/applications/console/geronimo-console- >>>> framework/pom.xml >>>> geronimo/server/trunk/applications/console/geronimo-console- >>>> standard/pom.xml >>>> geronimo/server/trunk/applications/geronimo-ca-helper/pom.xml >>>> geronimo/server/trunk/applications/geronimo-examples/ >>>> geronimo-jsp-examples/pom.xml >>>> geronimo/server/trunk/applications/geronimo-ldap-demo/pom.xml >>>> geronimo/server/trunk/applications/geronimo-remote-deploy/ >>>> pom.xml >>>> geronimo/server/trunk/applications/geronimo-uddi-server/pom.xml >>>> geronimo/server/trunk/applications/geronimo-welcome/pom.xml >>>> >>>> Modified: geronimo/server/trunk/applications/console/geronimo- >>>> console-framework/pom.xml >>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ >>>> applications/console/geronimo-console-framework/pom.xml? >>>> view=diff&rev=544258&r1=544257&r2=544258 >>>> =================================================================== >>>> =========== >>>> --- geronimo/server/trunk/applications/console/geronimo-console- >>>> framework/pom.xml (original) >>>> +++ geronimo/server/trunk/applications/console/geronimo-console- >>>> framework/pom.xml Mon Jun 4 13:44:49 2007 >>>> @@ -86,6 +86,9 @@ >>>> >>>> org.codehaus.mojo.jspc >>>> jspc-maven-plugin >>>> + >>>> + <!-- [INSERT FRAGMENT >>>> HERE] --> >>>> + >>>> >>>> >>>> >>>> >>>> Modified: geronimo/server/trunk/applications/console/geronimo- >>>> console-standard/pom.xml >>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ >>>> applications/console/geronimo-console-standard/pom.xml? >>>> view=diff&rev=544258&r1=544257&r2=544258 >>>> =================================================================== >>>> =========== >>>> --- geronimo/server/trunk/applications/console/geronimo-console- >>>> standard/pom.xml (original) >>>> +++ geronimo/server/trunk/applications/console/geronimo-console- >>>> standard/pom.xml Mon Jun 4 13:44:49 2007 >>>> @@ -142,6 +142,9 @@ >>>> >>>> org.codehaus.mojo.jspc >>>> jspc-maven-plugin >>>> + >>>> + <!-- [INSERT FRAGMENT >>>> HERE] --> >>>> + >>>> >>>> >>>> >>>> >>>> Modified: geronimo/server/trunk/applications/geronimo-ca-helper/ >>>> pom.xml >>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ >>>> applications/geronimo-ca-helper/pom.xml? >>>> view=diff&rev=544258&r1=544257&r2=544258 >>>> =================================================================== >>>> =========== >>>> --- geronimo/server/trunk/applications/geronimo-ca-helper/ >>>> pom.xml (original) >>>> +++ geronimo/server/trunk/applications/geronimo-ca-helper/ >>>> pom.xml Mon Jun 4 13:44:49 2007 >>>> @@ -73,6 +73,9 @@ >>>> >>>> org.codehaus.mojo.jspc >>>> jspc-maven-plugin >>>> + >>>> + <!-- [INSERT FRAGMENT >>>> HERE] --> >>>> + >>>> >>>> >>>> >>>> >>>> Modified: geronimo/server/trunk/applications/geronimo-examples/ >>>> geronimo-jsp-examples/pom.xml >>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ >>>> applications/geronimo-examples/geronimo-jsp-examples/pom.xml? >>>> view=diff&rev=544258&r1=544257&r2=544258 >>>> =================================================================== >>>> =========== >>>> --- geronimo/server/trunk/applications/geronimo-examples/ >>>> geronimo-jsp-examples/pom.xml (original) >>>> +++ geronimo/server/trunk/applications/geronimo-examples/ >>>> geronimo-jsp-examples/pom.xml Mon Jun 4 13:44:49 2007 >>>> @@ -60,6 +60,9 @@ >>>> >>>> org.codehaus.mojo.jspc >>>> jspc-maven-plugin >>>> + >>>> + <!-- [INSERT FRAGMENT >>>> HERE] --> >>>> + >>>> >>>> >>>> >>>> >>>> Modified: geronimo/server/trunk/applications/geronimo-ldap-demo/ >>>> pom.xml >>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ >>>> applications/geronimo-ldap-demo/pom.xml? >>>> view=diff&rev=544258&r1=544257&r2=544258 >>>> =================================================================== >>>> =========== >>>> --- geronimo/server/trunk/applications/geronimo-ldap-demo/ >>>> pom.xml (original) >>>> +++ geronimo/server/trunk/applications/geronimo-ldap-demo/ >>>> pom.xml Mon Jun 4 13:44:49 2007 >>>> @@ -46,6 +46,9 @@ >>>> >>>> org.codehaus.mojo.jspc >>>> jspc-maven-plugin >>>> + >>>> + <!-- [INSERT FRAGMENT >>>> HERE] --> >>>> + >>>> >>>> >>>> >>>> >>>> Modified: geronimo/server/trunk/applications/geronimo-remote- >>>> deploy/pom.xml >>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ >>>> applications/geronimo-remote-deploy/pom.xml? >>>> view=diff&rev=544258&r1=544257&r2=544258 >>>> =================================================================== >>>> =========== >>>> --- geronimo/server/trunk/applications/geronimo-remote-deploy/ >>>> pom.xml (original) >>>> +++ geronimo/server/trunk/applications/geronimo-remote-deploy/ >>>> pom.xml Mon Jun 4 13:44:49 2007 >>>> @@ -60,6 +60,9 @@ >>>> >>>> org.codehaus.mojo.jspc >>>> jspc-maven-plugin >>>> + >>>> + <!-- [INSERT FRAGMENT >>>> HERE] --> >>>> + >>>> >>>> >>>> >>>> >>>> Modified: geronimo/server/trunk/applications/geronimo-uddi- >>>> server/pom.xml >>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ >>>> applications/geronimo-uddi-server/pom.xml? >>>> view=diff&rev=544258&r1=544257&r2=544258 >>>> =================================================================== >>>> =========== >>>> --- geronimo/server/trunk/applications/geronimo-uddi-server/ >>>> pom.xml (original) >>>> +++ geronimo/server/trunk/applications/geronimo-uddi-server/ >>>> pom.xml Mon Jun 4 13:44:49 2007 >>>> @@ -54,6 +54,9 @@ >>>> >>>> org.codehaus.mojo.jspc >>>> jspc-maven-plugin >>>> + >>>> + <!-- [INSERT FRAGMENT >>>> HERE] --> >>>> + >>>> >>>> >>>> >>>> >>>> Modified: geronimo/server/trunk/applications/geronimo-welcome/ >>>> pom.xml >>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ >>>> applications/geronimo-welcome/pom.xml? >>>> view=diff&rev=544258&r1=544257&r2=544258 >>>> =================================================================== >>>> =========== >>>> --- geronimo/server/trunk/applications/geronimo-welcome/pom.xml >>>> (original) >>>> +++ geronimo/server/trunk/applications/geronimo-welcome/pom.xml >>>> Mon Jun 4 13:44:49 2007 >>>> @@ -66,6 +66,9 @@ >>>> >>>> org.codehaus.mojo.jspc >>>> jspc-maven-plugin >>>> + >>>> + <!-- [INSERT FRAGMENT >>>> HERE] --> >>>> + >>>> >>>> >>>> >>>> >>>> >>> >> >