geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Dillon <ja...@planet57.com>
Subject Re: svn commit: r544258 - in /geronimo/server/trunk/applications: console/geronimo-console-framework/ console/geronimo-console-standard/ geronimo-ca-helper/ geronimo-examples/geronimo-jsp-examples/ geronimo-ldap-demo/ geronimo-remote-deploy/ geronimo-uddi-...
Date Tue, 05 Jun 2007 05:21:23 GMT
 From what I could tell, the previous jspc plugin didn't use that  
string for a default replace token, instead it used '</web-app>' if  
the injectString was not configured.  The new plugin behaves the same  
way.

So... I'm not sure how the previous plugin handles replacing '<!--  
[INSERT FRAGMENT HERE] -->' with the fragment w/o this configuration.

What errors does it produce?  I ran the build a few times and it did  
not produce any errors.

--jason


On Jun 4, 2007, at 7:17 PM, Paul McMahan wrote:

> GERONIMO-3209 shows a build error that I and two others hit.  From  
> a brief conversation with Jeff on IRC, it seems that the current  
> jspc plugin no longer supports the default placeholder keyword used  
> by the geronimo applications:
>   <!-- [INSERT FRAGMENT HERE] -->
> This commit fixes the build error.
>
> Best wishes,
> Paul
>
> On Jun 4, 2007, at 6:38 PM, Jason Dillon wrote:
>
>> Why is this needed?
>>
>> --jason
>>
>>
>> On Jun 4, 2007, at 1:44 PM, pmcmahan@apache.org wrote:
>>
>>> Author: pmcmahan
>>> Date: Mon Jun  4 13:44:49 2007
>>> New Revision: 544258
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=544258
>>> Log:
>>> GERONIMO-3209 jspc maven plugin fails in some environments when  
>>> the injectString is not explicitly declared
>>>
>>> Modified:
>>>     geronimo/server/trunk/applications/console/geronimo-console- 
>>> framework/pom.xml
>>>     geronimo/server/trunk/applications/console/geronimo-console- 
>>> standard/pom.xml
>>>     geronimo/server/trunk/applications/geronimo-ca-helper/pom.xml
>>>     geronimo/server/trunk/applications/geronimo-examples/geronimo- 
>>> jsp-examples/pom.xml
>>>     geronimo/server/trunk/applications/geronimo-ldap-demo/pom.xml
>>>     geronimo/server/trunk/applications/geronimo-remote-deploy/ 
>>> pom.xml
>>>     geronimo/server/trunk/applications/geronimo-uddi-server/pom.xml
>>>     geronimo/server/trunk/applications/geronimo-welcome/pom.xml
>>>
>>> Modified: geronimo/server/trunk/applications/console/geronimo- 
>>> console-framework/pom.xml
>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ 
>>> applications/console/geronimo-console-framework/pom.xml? 
>>> view=diff&rev=544258&r1=544257&r2=544258
>>> ==================================================================== 
>>> ==========
>>> --- geronimo/server/trunk/applications/console/geronimo-console- 
>>> framework/pom.xml (original)
>>> +++ geronimo/server/trunk/applications/console/geronimo-console- 
>>> framework/pom.xml Mon Jun  4 13:44:49 2007
>>> @@ -86,6 +86,9 @@
>>>              <plugin>
>>>                  <groupId>org.codehaus.mojo.jspc</groupId>
>>>                  <artifactId>jspc-maven-plugin</artifactId>
>>> +                <configuration>
>>> +                    <injectString>&lt;!-- [INSERT FRAGMENT HERE] 

>>> --&gt;</injectString>
>>> +                </configuration>
>>>              </plugin>
>>>
>>>              <plugin>
>>>
>>> Modified: geronimo/server/trunk/applications/console/geronimo- 
>>> console-standard/pom.xml
>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ 
>>> applications/console/geronimo-console-standard/pom.xml? 
>>> view=diff&rev=544258&r1=544257&r2=544258
>>> ==================================================================== 
>>> ==========
>>> --- geronimo/server/trunk/applications/console/geronimo-console- 
>>> standard/pom.xml (original)
>>> +++ geronimo/server/trunk/applications/console/geronimo-console- 
>>> standard/pom.xml Mon Jun  4 13:44:49 2007
>>> @@ -142,6 +142,9 @@
>>>              <plugin>
>>>                  <groupId>org.codehaus.mojo.jspc</groupId>
>>>                  <artifactId>jspc-maven-plugin</artifactId>
>>> +                <configuration>
>>> +                    <injectString>&lt;!-- [INSERT FRAGMENT HERE] 

>>> --&gt;</injectString>
>>> +                </configuration>
>>>              </plugin>
>>>
>>>              <plugin>
>>>
>>> Modified: geronimo/server/trunk/applications/geronimo-ca-helper/ 
>>> pom.xml
>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ 
>>> applications/geronimo-ca-helper/pom.xml? 
>>> view=diff&rev=544258&r1=544257&r2=544258
>>> ==================================================================== 
>>> ==========
>>> --- geronimo/server/trunk/applications/geronimo-ca-helper/pom.xml  
>>> (original)
>>> +++ geronimo/server/trunk/applications/geronimo-ca-helper/pom.xml  
>>> Mon Jun  4 13:44:49 2007
>>> @@ -73,6 +73,9 @@
>>>              <plugin>
>>>                  <groupId>org.codehaus.mojo.jspc</groupId>
>>>                  <artifactId>jspc-maven-plugin</artifactId>
>>> +                <configuration>
>>> +                    <injectString>&lt;!-- [INSERT FRAGMENT HERE] 

>>> --&gt;</injectString>
>>> +                </configuration>
>>>              </plugin>
>>>
>>>              <plugin>
>>>
>>> Modified: geronimo/server/trunk/applications/geronimo-examples/ 
>>> geronimo-jsp-examples/pom.xml
>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ 
>>> applications/geronimo-examples/geronimo-jsp-examples/pom.xml? 
>>> view=diff&rev=544258&r1=544257&r2=544258
>>> ==================================================================== 
>>> ==========
>>> --- geronimo/server/trunk/applications/geronimo-examples/geronimo- 
>>> jsp-examples/pom.xml (original)
>>> +++ geronimo/server/trunk/applications/geronimo-examples/geronimo- 
>>> jsp-examples/pom.xml Mon Jun  4 13:44:49 2007
>>> @@ -60,6 +60,9 @@
>>>              <plugin>
>>>                  <groupId>org.codehaus.mojo.jspc</groupId>
>>>                  <artifactId>jspc-maven-plugin</artifactId>
>>> +                <configuration>
>>> +                    <injectString>&lt;!-- [INSERT FRAGMENT HERE] 

>>> --&gt;</injectString>
>>> +                </configuration>
>>>              </plugin>
>>>
>>>              <plugin>
>>>
>>> Modified: geronimo/server/trunk/applications/geronimo-ldap-demo/ 
>>> pom.xml
>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ 
>>> applications/geronimo-ldap-demo/pom.xml? 
>>> view=diff&rev=544258&r1=544257&r2=544258
>>> ==================================================================== 
>>> ==========
>>> --- geronimo/server/trunk/applications/geronimo-ldap-demo/pom.xml  
>>> (original)
>>> +++ geronimo/server/trunk/applications/geronimo-ldap-demo/pom.xml  
>>> Mon Jun  4 13:44:49 2007
>>> @@ -46,6 +46,9 @@
>>>              <plugin>
>>>                  <groupId>org.codehaus.mojo.jspc</groupId>
>>>                  <artifactId>jspc-maven-plugin</artifactId>
>>> +                <configuration>
>>> +                    <injectString>&lt;!-- [INSERT FRAGMENT HERE] 

>>> --&gt;</injectString>
>>> +                </configuration>
>>>              </plugin>
>>>
>>>              <plugin>
>>>
>>> Modified: geronimo/server/trunk/applications/geronimo-remote- 
>>> deploy/pom.xml
>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ 
>>> applications/geronimo-remote-deploy/pom.xml? 
>>> view=diff&rev=544258&r1=544257&r2=544258
>>> ==================================================================== 
>>> ==========
>>> --- geronimo/server/trunk/applications/geronimo-remote-deploy/ 
>>> pom.xml (original)
>>> +++ geronimo/server/trunk/applications/geronimo-remote-deploy/ 
>>> pom.xml Mon Jun  4 13:44:49 2007
>>> @@ -60,6 +60,9 @@
>>>              <plugin>
>>>                  <groupId>org.codehaus.mojo.jspc</groupId>
>>>                  <artifactId>jspc-maven-plugin</artifactId>
>>> +                <configuration>
>>> +                    <injectString>&lt;!-- [INSERT FRAGMENT HERE] 

>>> --&gt;</injectString>
>>> +                </configuration>
>>>              </plugin>
>>>
>>>              <plugin>
>>>
>>> Modified: geronimo/server/trunk/applications/geronimo-uddi-server/ 
>>> pom.xml
>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ 
>>> applications/geronimo-uddi-server/pom.xml? 
>>> view=diff&rev=544258&r1=544257&r2=544258
>>> ==================================================================== 
>>> ==========
>>> --- geronimo/server/trunk/applications/geronimo-uddi-server/ 
>>> pom.xml (original)
>>> +++ geronimo/server/trunk/applications/geronimo-uddi-server/ 
>>> pom.xml Mon Jun  4 13:44:49 2007
>>> @@ -54,6 +54,9 @@
>>>              <plugin>
>>>                  <groupId>org.codehaus.mojo.jspc</groupId>
>>>                  <artifactId>jspc-maven-plugin</artifactId>
>>> +                <configuration>
>>> +                    <injectString>&lt;!-- [INSERT FRAGMENT HERE] 

>>> --&gt;</injectString>
>>> +                </configuration>
>>>              </plugin>
>>>
>>>              <plugin>
>>>
>>> Modified: geronimo/server/trunk/applications/geronimo-welcome/ 
>>> pom.xml
>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ 
>>> applications/geronimo-welcome/pom.xml? 
>>> view=diff&rev=544258&r1=544257&r2=544258
>>> ==================================================================== 
>>> ==========
>>> --- geronimo/server/trunk/applications/geronimo-welcome/pom.xml  
>>> (original)
>>> +++ geronimo/server/trunk/applications/geronimo-welcome/pom.xml  
>>> Mon Jun  4 13:44:49 2007
>>> @@ -66,6 +66,9 @@
>>>              <plugin>
>>>                  <groupId>org.codehaus.mojo.jspc</groupId>
>>>                  <artifactId>jspc-maven-plugin</artifactId>
>>> +                <configuration>
>>> +                    <injectString>&lt;!-- [INSERT FRAGMENT HERE] 

>>> --&gt;</injectString>
>>> +                </configuration>
>>>              </plugin>
>>>
>>>              <plugin>
>>>
>>>
>>
>


Mime
View raw message