geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jay D. McHugh (JIRA)" <j...@apache.org>
Subject [jira] Commented: (GERONIMO-1265) Preserve comments added by users in the config.xml file
Date Wed, 27 Jun 2007 03:06:26 GMT

    [ https://issues.apache.org/jira/browse/GERONIMO-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508389
] 

Jay D. McHugh commented on GERONIMO-1265:
-----------------------------------------

I took a look at the patch and it does work as intended.

And, it would probably be a good start to including comments in the config.xml file.

But I'm thinking that if the schema is being updated then:
1) The version should get incremented (1.1 -> 1.2 or 1.1.1).
2) We should go ahead and add support to the schema to have comments at just about any location.

Does anyone else have any thoughts on the schema?

> Preserve comments added by users in the config.xml file
> -------------------------------------------------------
>
>                 Key: GERONIMO-1265
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-1265
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: startup/shutdown, usability
>    Affects Versions: 1.0-M5, 1.0, 1.1, 1.1.1, 1.1.2, 1.1.x, 1.2
>            Reporter: John Sisson
>             Fix For: 1.x, 2.0-M5
>
>         Attachments: geronimo-1265.patch
>
>
> Currently if a user adds comments to the config.xml file, they will be lost when Geronimo
re-generates the file if a configuration change is made (e.g. through the web console).
> As a temporary measure, the code that re-generates the XML will place a warning at the
top of the file warning users not to place comments in it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message