geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anita Kulshreshtha <a_kuls...@yahoo.com>
Subject Re: svn commit: r544258 - in /geronimo/server/trunk/applications: console/geronimo-console-framework/ console/geronimo-console-standard/ geronimo-ca-helper/ geronimo-examples/geronimo-jsp-examples/ geronimo-ldap-demo/ geronimo-remote-deploy/ geronimo-uddi-...
Date Tue, 05 Jun 2007 14:18:05 GMT
   It would be interesting to know if all four error cases did a
partial build (i.e. application, config, assembly) without mvn -N from
the top directory.

 
Thanks
Anita

--- Paul McMahan <paulmcmahan@gmail.com> wrote:

> I know of four developers that hit the error, but don't understand  
> why everyone didn't hit it. 
   Could be Maven magic!!! It would be interesting to know if all four
error cases did a partial build (i.e. application, config, assembly)
without mvn -N from the top directory.

 
Thanks
Anita
> Without the change I see the build error
>  
> reported in GERONIMO-3209.  I think that the previous plugin looked  
> for '<!-- [INSERT FRAGMENT HERE] -->' by default and the new one does
>  
> not.  The result is that that placeholder string is left in web.xml  
> which results in a parse error when geronimo tries to deploy it while
>  
> building the configs.
> 
> Best wishes,
> Paul
> 
> On Jun 5, 2007, at 1:21 AM, Jason Dillon wrote:
> 
> > From what I could tell, the previous jspc plugin didn't use that  
> > string for a default replace token, instead it used '</web-app>' if
>  
> > the injectString was not configured.  The new plugin behaves the  
> > same way.
> >
> > So... I'm not sure how the previous plugin handles replacing '<!-- 
> 
> > [INSERT FRAGMENT HERE] -->' with the fragment w/o this
> configuration.
> >
> > What errors does it produce?  I ran the build a few times and it  
> > did not produce any errors.
> >
> > --jason
> >
> >
> > On Jun 4, 2007, at 7:17 PM, Paul McMahan wrote:
> >
> >> GERONIMO-3209 shows a build error that I and two others hit.  From
>  
> >> a brief conversation with Jeff on IRC, it seems that the current  
> >> jspc plugin no longer supports the default placeholder keyword  
> >> used by the geronimo applications:
> >>   <!-- [INSERT FRAGMENT HERE] -->
> >> This commit fixes the build error.
> >>
> >> Best wishes,
> >> Paul
> >>
> >> On Jun 4, 2007, at 6:38 PM, Jason Dillon wrote:
> >>
> >>> Why is this needed?
> >>>
> >>> --jason
> >>>
> >>>
> >>> On Jun 4, 2007, at 1:44 PM, pmcmahan@apache.org wrote:
> >>>
> >>>> Author: pmcmahan
> >>>> Date: Mon Jun  4 13:44:49 2007
> >>>> New Revision: 544258
> >>>>
> >>>> URL: http://svn.apache.org/viewvc?view=rev&rev=544258
> >>>> Log:
> >>>> GERONIMO-3209 jspc maven plugin fails in some environments when 
> 
> >>>> the injectString is not explicitly declared
> >>>>
> >>>> Modified:
> >>>>     geronimo/server/trunk/applications/console/geronimo-console-
> 
> >>>> framework/pom.xml
> >>>>     geronimo/server/trunk/applications/console/geronimo-console-
> 
> >>>> standard/pom.xml
> >>>>    
> geronimo/server/trunk/applications/geronimo-ca-helper/pom.xml
> >>>>     geronimo/server/trunk/applications/geronimo-examples/ 
> >>>> geronimo-jsp-examples/pom.xml
> >>>>    
> geronimo/server/trunk/applications/geronimo-ldap-demo/pom.xml
> >>>>     geronimo/server/trunk/applications/geronimo-remote-deploy/ 
> >>>> pom.xml
> >>>>    
> geronimo/server/trunk/applications/geronimo-uddi-server/pom.xml
> >>>>     geronimo/server/trunk/applications/geronimo-welcome/pom.xml
> >>>>
> >>>> Modified: geronimo/server/trunk/applications/console/geronimo- 
> >>>> console-framework/pom.xml
> >>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ 
> >>>> applications/console/geronimo-console-framework/pom.xml? 
> >>>> view=diff&rev=544258&r1=544257&r2=544258
> >>>>
> =================================================================== 
> >>>> ===========
> >>>> --- geronimo/server/trunk/applications/console/geronimo-console-
> 
> >>>> framework/pom.xml (original)
> >>>> +++ geronimo/server/trunk/applications/console/geronimo-console-
> 
> >>>> framework/pom.xml Mon Jun  4 13:44:49 2007
> >>>> @@ -86,6 +86,9 @@
> >>>>              <plugin>
> >>>>                  <groupId>org.codehaus.mojo.jspc</groupId>
> >>>>                  <artifactId>jspc-maven-plugin</artifactId>
> >>>> +                <configuration>
> >>>> +                    <injectString>&lt;!-- [INSERT FRAGMENT
 
> >>>> HERE] --&gt;</injectString>
> >>>> +                </configuration>
> >>>>              </plugin>
> >>>>
> >>>>              <plugin>
> >>>>
> >>>> Modified: geronimo/server/trunk/applications/console/geronimo- 
> >>>> console-standard/pom.xml
> >>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ 
> >>>> applications/console/geronimo-console-standard/pom.xml? 
> >>>> view=diff&rev=544258&r1=544257&r2=544258
> >>>>
> =================================================================== 
> >>>> ===========
> >>>> --- geronimo/server/trunk/applications/console/geronimo-console-
> 
> >>>> standard/pom.xml (original)
> >>>> +++ geronimo/server/trunk/applications/console/geronimo-console-
> 
> >>>> standard/pom.xml Mon Jun  4 13:44:49 2007
> >>>> @@ -142,6 +142,9 @@
> >>>>              <plugin>
> >>>>                  <groupId>org.codehaus.mojo.jspc</groupId>
> >>>>                  <artifactId>jspc-maven-plugin</artifactId>
> >>>> +                <configuration>
> >>>> +                    <injectString>&lt;!-- [INSERT FRAGMENT
 
> >>>> HERE] --&gt;</injectString>
> >>>> +                </configuration>
> >>>>              </plugin>
> >>>>
> >>>>              <plugin>
> >>>>
> >>>> Modified: geronimo/server/trunk/applications/geronimo-ca-helper/
> 
> >>>> pom.xml
> >>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ 
> >>>> applications/geronimo-ca-helper/pom.xml? 
> >>>> view=diff&rev=544258&r1=544257&r2=544258
> >>>>
> =================================================================== 
> >>>> ===========
> >>>> --- geronimo/server/trunk/applications/geronimo-ca-helper/ 
> >>>> pom.xml (original)
> >>>> +++ geronimo/server/trunk/applications/geronimo-ca-helper/ 
> >>>> pom.xml Mon Jun  4 13:44:49 2007
> >>>> @@ -73,6 +73,9 @@
> >>>>              <plugin>
> >>>>                  <groupId>org.codehaus.mojo.jspc</groupId>
> >>>>                  <artifactId>jspc-maven-plugin</artifactId>
> >>>> +                <configuration>
> >>>> +                    <injectString>&lt;!-- [INSERT FRAGMENT
 
> >>>> HERE] --&gt;</injectString>
> >>>> +                </configuration>
> >>>>              </plugin>
> >>>>
> >>>>              <plugin>
> >>>>
> >>>> Modified: geronimo/server/trunk/applications/geronimo-examples/ 
> >>>> geronimo-jsp-examples/pom.xml
> >>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ 
> >>>> applications/geronimo-examples/geronimo-jsp-examples/pom.xml? 
> >>>> view=diff&rev=544258&r1=544257&r2=544258
> >>>>
> =================================================================== 
> >>>> ===========
> >>>> --- geronimo/server/trunk/applications/geronimo-examples/ 
> >>>> geronimo-jsp-examples/pom.xml (original)
> >>>> +++ geronimo/server/trunk/applications/geronimo-examples/ 
> >>>> geronimo-jsp-examples/pom.xml Mon Jun  4 13:44:49 2007
> >>>> @@ -60,6 +60,9 @@
> >>>>              <plugin>
> >>>>                  <groupId>org.codehaus.mojo.jspc</groupId>
> >>>>                  <artifactId>jspc-maven-plugin</artifactId>
> >>>> +                <configuration>
> >>>> +                    <injectString>&lt;!-- [INSERT FRAGMENT
 
> >>>> HERE] --&gt;</injectString>
> >>>> +                </configuration>
> >>>>              </plugin>
> >>>>
> >>>>              <plugin>
> >>>>
> >>>> Modified: geronimo/server/trunk/applications/geronimo-ldap-demo/
> 
> >>>> pom.xml
> >>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ 
> >>>> applications/geronimo-ldap-demo/pom.xml? 
> >>>> view=diff&rev=544258&r1=544257&r2=544258
> >>>>
> =================================================================== 
> >>>> ===========
> >>>> --- geronimo/server/trunk/applications/geronimo-ldap-demo/ 
> >>>> pom.xml (original)
> >>>> +++ geronimo/server/trunk/applications/geronimo-ldap-demo/ 
> >>>> pom.xml Mon Jun  4 13:44:49 2007
> >>>> @@ -46,6 +46,9 @@
> >>>>              <plugin>
> >>>>                  <groupId>org.codehaus.mojo.jspc</groupId>
> 
=== message truncated ===



       
____________________________________________________________________________________
Choose the right car based on your needs.  Check out Yahoo! Autos new Car Finder tool.
http://autos.yahoo.com/carfinder/

Mime
View raw message