Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 20801 invoked from network); 26 May 2007 11:35:05 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 26 May 2007 11:35:05 -0000 Received: (qmail 58031 invoked by uid 500); 26 May 2007 11:35:08 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 57987 invoked by uid 500); 26 May 2007 11:35:08 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 57976 invoked by uid 99); 26 May 2007 11:35:08 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 26 May 2007 04:35:08 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [68.142.201.195] (HELO web31715.mail.mud.yahoo.com) (68.142.201.195) by apache.org (qpsmtpd/0.29) with SMTP; Sat, 26 May 2007 04:35:02 -0700 Received: (qmail 74407 invoked by uid 60001); 26 May 2007 11:34:40 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=X-YMail-OSG:Received:Date:From:Subject:To:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID; b=ukccC+VPehGKtKj7ihrCHbBkAjzVCRUjUP3kjCZZBs7swmrtAw1mh30EgmQFJ4dxtKRARltLMbFpynPMMX5wrWy2tW+4LAyerN4B3XJSn3ZLSQzbeuM/UdaOOj85VzQ/eWem1Oi8HOn2zx7g8nqN0DaI0ClxymbsveEYF4KX8cw=; X-YMail-OSG: K4F5ikkVM1nLLwhwHardDRAF9ojxh2IhxxToCFhPwsvBsL40jC29GGDkQbRlw9.ePKuIVNWadt3faTcVY_kQotfKw3A0iOy4HAhw5k7kzLm5RAAahUoS9LrjMQ-- Received: from [24.211.208.98] by web31715.mail.mud.yahoo.com via HTTP; Sat, 26 May 2007 04:34:40 PDT Date: Sat, 26 May 2007 04:34:40 -0700 (PDT) From: Anita Kulshreshtha Subject: Re: svn commit: r541850 - in /geronimo/server/trunk/modules/geronimo-jetty6/src/main/java/org/apache/geronimo/jetty6: JettyManagerImpl.java connector/JettyConnector.java To: dev@geronimo.apache.org In-Reply-To: <9A193DD1-8542-438C-ADB1-84825489C626@yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <560762.74394.qm@web31715.mail.mud.yahoo.com> X-Virus-Checked: Checked by ClamAV on apache.org AJP* classes are not included in jetty-6.1 jar like their earlier counterparts in jetty5. Are they going to be included soon? I do see a org.mortbay.jetty.ajp at http://www.mortbay.org/apidocs/index.html. Thanks Anita --- David Jencks wrote: > This might be a bit misleading since I think there is in fact an ajp > > connector for jetty, we just haven't wrapped it yet. > > thanks > david jencks > > On May 25, 2007, at 7:46 PM, akulshreshtha@apache.org wrote: > > > Author: akulshreshtha > > Date: Fri May 25 19:46:15 2007 > > New Revision: 541850 > > > > URL: http://svn.apache.org/viewvc?view=rev&rev=541850 > > Log: > > GERONIMO-2773 - Removed minThreads, tcpNoDelay attributes from > > JettyConnector, and added protocol, Mark AJP as unsupported > protocol > > > > Modified: > > > geronimo/server/trunk/modules/geronimo-jetty6/src/main/java/org/ > > apache/geronimo/jetty6/JettyManagerImpl.java > > > geronimo/server/trunk/modules/geronimo-jetty6/src/main/java/org/ > > apache/geronimo/jetty6/connector/JettyConnector.java > > > > Modified: geronimo/server/trunk/modules/geronimo-jetty6/src/main/ > > java/org/apache/geronimo/jetty6/JettyManagerImpl.java > > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/ > > geronimo-jetty6/src/main/java/org/apache/geronimo/jetty6/ > > JettyManagerImpl.java?view=diff&rev=541850&r1=541849&r2=541850 > > > ====================================================================== > > > ======== > > --- > geronimo/server/trunk/modules/geronimo-jetty6/src/main/java/org/ > > apache/geronimo/jetty6/JettyManagerImpl.java (original) > > +++ > geronimo/server/trunk/modules/geronimo-jetty6/src/main/java/org/ > > apache/geronimo/jetty6/JettyManagerImpl.java Fri May 25 19:46:15 > 2007 > > @@ -82,14 +82,18 @@ > > AbstractNameQuery query = new AbstractNameQuery > > (KeystoreManager.class.getName()); > > connector.setReferencePattern("KeystoreManager", > query); > > //todo: default HTTPS settings > > - } else if (protocol.equals(PROTOCOL_AJP)) { > > - connector = new GBeanData(name, > > AJP13Connector.GBEAN_INFO); > > - } else { > > + } > > + // Note: AJP Connector is not yet supported by Jetty > > + // else if (protocol.equals(PROTOCOL_AJP)) { > > + // connector = new GBeanData(name, > > AJP13Connector.GBEAN_INFO); > > + //} > > + else { > > throw new IllegalArgumentException("Invalid protocol > > '" + protocol + "'"); > > } > > connector.setAttribute("host", host); > > connector.setAttribute("port", new Integer(port)); > > - connector.setAttribute("minThreads", new Integer(10)); > > + //connector.setAttribute("minThreads", new Integer(10)); > > + connector.setAttribute("protocol", protocol); > > connector.setAttribute("maxThreads", new Integer(50)); > > connector.setReferencePattern > > (JettyConnector.CONNECTOR_CONTAINER_REFERENCE, containerName); > > EditableConfigurationManager mgr = > > ConfigurationUtil.getEditableConfigurationManager(kernel); > > @@ -130,7 +134,11 @@ > > * connectors for). > > */ > > public String[] getSupportedProtocols() { > > - return new String[]{PROTOCOL_HTTP, PROTOCOL_HTTPS, > > PROTOCOL_AJP}; > > + return new String[]{PROTOCOL_HTTP, PROTOCOL_HTTPS}; > > + // > > + // AJP Connector is not yet supported by Jetty > > + // so leave out 'PROTOCOL_AJP' for now > > + // > > } > > > > /** > > > > Modified: geronimo/server/trunk/modules/geronimo-jetty6/src/main/ > > java/org/apache/geronimo/jetty6/connector/JettyConnector.java > > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/ > > geronimo-jetty6/src/main/java/org/apache/geronimo/jetty6/connector/ > > > JettyConnector.java?view=diff&rev=541850&r1=541849&r2=541850 > > > ====================================================================== > > > ======== > > --- > geronimo/server/trunk/modules/geronimo-jetty6/src/main/java/org/ > > apache/geronimo/jetty6/connector/JettyConnector.java (original) > > +++ > geronimo/server/trunk/modules/geronimo-jetty6/src/main/java/org/ > > apache/geronimo/jetty6/connector/JettyConnector.java Fri May 25 > > 19:46:15 2007 > > @@ -236,8 +236,11 @@ > > static { > > GBeanInfoBuilder infoFactory = > > GBeanInfoBuilder.createStatic("Jetty HTTP Connector", > > JettyConnector.class); > > infoFactory.addReference(CONNECTOR_CONTAINER_REFERENCE, > > JettyContainer.class, NameFactory.GERONIMO_SERVICE); > > - infoFactory.addInterface(JettyWebConnector.class, new > > String[]{"host", "port", "minThreads", "maxThreads", > > "bufferSizeBytes", "acceptQueueSize", "lingerMillis", "tcpNoDelay", > > > "redirectPort", "connectUrl", "maxIdleTimeMs"}, > > - new String[]{"host", "port", "redirectPort", > > "maxThreads", "minThreads"}); > > + // removed 'minThreads' from persistent and manageable > > String[] > > + // removed 'tcpNoDelay' from persistent String[] > > + // added 'protocol' to persistent and manageable String[] > > + infoFactory.addInterface(JettyWebConnector.class, new > > String[]{"host", "port", "minThreads", "maxThreads", > > "bufferSizeBytes", "acceptQueueSize", "lingerMillis", "protocol", > > "redirectPort", "connectUrl", "maxIdleTimeMs"}, > > + new String[]{"host", "port", "redirectPort", > > "maxThreads", "minThreads", "protocol"}); > > infoFactory.setConstructor(new > String[]{"JettyContainer"}); > > GBEAN_INFO = infoFactory.getBeanInfo(); > > } > > > > > > ____________________________________________________________________________________Sick sense of humor? Visit Yahoo! TV's Comedy with an Edge to see what's on, when. http://tv.yahoo.com/collections/222