geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anita Kulshreshtha <a_kuls...@yahoo.com>
Subject Re: svn commit: r534454 - in /geronimo/server/trunk: assemblies/geronimo-boilerplate-minimal/src/main/resources/bin/ maven-plugins/geronimo-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/geronimo/server/
Date Wed, 02 May 2007 14:20:08 GMT
Before rev533500, if the server was started from the scripts,
java.io.tmpdir was resolved to GHOME/var/temp (not relative to an
instance). If it was started using java -jar...., it used the system
default temp. The new behavior will allow each instance to have its own
temp, i.e.
1. If java.io.tmpdir is not specified, default to system temp as before
2. if java.io.tmpdir is relative, resolve relative to each instance
3. if java.io.tmpdir is absolute, use this as a tmpdir as before 
   The server does not use user.dir. ServerInfo is used to determine
the installation directory of geronimo. This value is used to resolve
all the paths for each instance.
   Hope this helps   
Thanks
Anita

--- Jason Dillon <jason@planet57.com> wrote:

> Um, are you sure this is correct?
> 
> <snip>
> setSystemProperty(java, "java.io.tmpdir", "var/temp");
> </snip>
> 
> I would expect this to resolve var/temp dir relative to the value of 
> 
> user.dir, which could be anywhere depending on what dir I was in when
>  
> I started up the process.
> 
> Also, why are we even bothering with stuff like '- 
> Djava.io.tmpdir="$GERONIMO_TMPDIR"' in these platform scripts?
> 
> Seriously, these scripts are *way too complicated* and really need to
>  
> be simplified dramatically.
> 
> --jason
> 
> 
> On May 2, 2007, at 6:39 AM, akulshreshtha@apache.org wrote:
> 
> > Author: akulshreshtha
> > Date: Wed May  2 06:39:49 2007
> > New Revision: 534454
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=534454
> > Log:
> > GERONIMO-3011 Few more relative java.io.tmpdir, This will resolve  
> > relative to GERONIMO_BASE.
> >
> > Modified:
> >     geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/ 
> > src/main/resources/bin/deploy.bat
> >     geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/ 
> > src/main/resources/bin/deploy.sh
> >     geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ 
> > main/java/org/apache/geronimo/mavenplugins/geronimo/server/ 
> > RunClientMojo.java
> >     geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ 
> > main/java/org/apache/geronimo/mavenplugins/geronimo/server/ 
> > StartServerMojo.java
> >
> > Modified: geronimo/server/trunk/assemblies/geronimo-boilerplate- 
> > minimal/src/main/resources/bin/deploy.bat
> > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/assemblies/
> 
> > geronimo-boilerplate-minimal/src/main/resources/bin/deploy.bat? 
> > view=diff&rev=534454&r1=534453&r2=534454
> >
>
======================================================================
> 
> > ========
> > --- geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/ 
> > src/main/resources/bin/deploy.bat (original)
> > +++ geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/ 
> > src/main/resources/bin/deploy.bat Wed May  2 06:39:49 2007
> > @@ -150,7 +150,7 @@
> >  :gotBase
> >
> >  if not "%GERONIMO_TMPDIR%" == "" goto gotTmpdir
> > -set GERONIMO_TMPDIR=%GERONIMO_BASE%\var\temp
> > +set GERONIMO_TMPDIR=var\temp
> >  :gotTmpdir
> >
> >  @REM ----- Execute The Requested Command  
> > ---------------------------------------
> >
> > Modified: geronimo/server/trunk/assemblies/geronimo-boilerplate- 
> > minimal/src/main/resources/bin/deploy.sh
> > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/assemblies/
> 
> > geronimo-boilerplate-minimal/src/main/resources/bin/deploy.sh? 
> > view=diff&rev=534454&r1=534453&r2=534454
> >
>
======================================================================
> 
> > ========
> > --- geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/ 
> > src/main/resources/bin/deploy.sh (original)
> > +++ geronimo/server/trunk/assemblies/geronimo-boilerplate-minimal/ 
> > src/main/resources/bin/deploy.sh Wed May  2 06:39:49 2007
> > @@ -167,7 +167,7 @@
> >
> >  if [ -z "$GERONIMO_TMPDIR" ] ; then
> >    # Define the java.io.tmpdir to use for Geronimo
> > -  GERONIMO_TMPDIR="$GERONIMO_BASE"/var/temp
> > +  GERONIMO_TMPDIR=var/temp
> >  fi
> >
> >  # For Cygwin, switch paths to Windows format before running java
> >
> > Modified:
> geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/ 
> > src/main/java/org/apache/geronimo/mavenplugins/geronimo/server/ 
> > RunClientMojo.java
> > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/maven- 
> > plugins/geronimo-maven-plugin/src/main/java/org/apache/geronimo/ 
> > mavenplugins/geronimo/server/RunClientMojo.java? 
> > view=diff&rev=534454&r1=534453&r2=534454
> >
>
======================================================================
> 
> > ========
> > --- geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ 
> > main/java/org/apache/geronimo/mavenplugins/geronimo/server/ 
> > RunClientMojo.java (original)
> > +++ geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ 
> > main/java/org/apache/geronimo/mavenplugins/geronimo/server/ 
> > RunClientMojo.java Wed May  2 06:39:49 2007
> > @@ -105,7 +105,7 @@
> >
> >          // Set the properties which we pass to the JVM from the  
> > startup script
> >          setSystemProperty(java, "org.apache.geronimo.base.dir",  
> > geronimoHome);
> > -        setSystemProperty(java, "java.io.tmpdir", new File 
> > (geronimoHome, "var/temp"));
> > +        setSystemProperty(java, "java.io.tmpdir", "var/temp");
> >          setSystemProperty(java, "java.endorsed.dirs",  
> > prefixSystemPath("java.endorsed.dirs", new File(geronimoHome, "lib/
> 
> > endorsed")));
> >          setSystemProperty(java, "java.ext.dirs", prefixSystemPath 
> > ("java.ext.dirs", new File(geronimoHome, "lib/ext")));
> >
> >
> > Modified:
> geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/ 
> > src/main/java/org/apache/geronimo/mavenplugins/geronimo/server/ 
> > StartServerMojo.java
> > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/maven- 
> > plugins/geronimo-maven-plugin/src/main/java/org/apache/geronimo/ 
> > mavenplugins/geronimo/server/StartServerMojo.java? 
> > view=diff&rev=534454&r1=534453&r2=534454
> >
>
======================================================================
> 
> > ========
> > --- geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ 
> > main/java/org/apache/geronimo/mavenplugins/geronimo/server/ 
> > StartServerMojo.java (original)
> > +++ geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ 
> > main/java/org/apache/geronimo/mavenplugins/geronimo/server/ 
> > StartServerMojo.java Wed May  2 06:39:49 2007
> > @@ -235,7 +235,8 @@
> >
> >          // Set the properties which we pass to the JVM from the  
> > startup script
> >          setSystemProperty(java, "org.apache.geronimo.base.dir",  
> > geronimoHome);
> > -        setSystemProperty(java, "java.io.tmpdir", new File 
> > (geronimoHome, "var/temp"));
> > +        // Use relative path
> > +        setSystemProperty(java, "java.io.tmpdir", "var/temp");
> >          setSystemProperty(java, "java.endorsed.dirs",  
> > prefixSystemPath("java.endorsed.dirs", new File(geronimoHome, "lib/
> 
> > endorsed")));
> >          setSystemProperty(java, "java.ext.dirs", prefixSystemPath 
> > ("java.ext.dirs", new File(geronimoHome, "lib/ext")));
> >
> >
> >
> 
> 


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

Mime
View raw message