geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Donald Woods <dwo...@apache.org>
Subject Re: svn commit: r526893 - in /geronimo/server/trunk/modules: geronimo-cxf/src/main/java/org/apache/geronimo/cxf/CXFGBean.java geronimo-webservices/src/main/java/org/apache/geronimo/webservices/SystemPropertyGBean.java
Date Tue, 10 Apr 2007 14:12:31 GMT
Never mind, just saw the other thread that Jason started and that you 
already switched it.


Donald Woods wrote:
> Any reason you are not using the existing GBean 
> org.apache.geronimo.system.properties.SystemProperties class for this, 
> which is in the geronimo-system module?
> 
> It was used extensively in 1.0/1.1 to set the Sun ORB system properties, 
> so you might have to look back to there to see how to use it in your 
> config.
> 
> -Donald
> 
> gawor@apache.org wrote:
>> Author: gawor
>> Date: Mon Apr  9 12:50:21 2007
>> New Revision: 526893
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=526893
>> Log:
>> switch to more generic gbean that sets system properties
>>
>> Added:
>>     
>> geronimo/server/trunk/modules/geronimo-webservices/src/main/java/org/apache/geronimo/webservices/SystemPropertyGBean.java
  
>> (with props)
>> Removed:
>>     
>> geronimo/server/trunk/modules/geronimo-cxf/src/main/java/org/apache/geronimo/cxf/CXFGBean.java

>>
>>
>> Added: 
>> geronimo/server/trunk/modules/geronimo-webservices/src/main/java/org/apache/geronimo/webservices/SystemPropertyGBean.java

>>
>> URL: 
>> http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-webservices/src/main/java/org/apache/geronimo/webservices/SystemPropertyGBean.java?view=auto&rev=526893

>>
>> ============================================================================== 
>>
>> --- 
>> geronimo/server/trunk/modules/geronimo-webservices/src/main/java/org/apache/geronimo/webservices/SystemPropertyGBean.java

>> (added)
>> +++ 
>> geronimo/server/trunk/modules/geronimo-webservices/src/main/java/org/apache/geronimo/webservices/SystemPropertyGBean.java

>> Mon Apr  9 12:50:21 2007
>> @@ -0,0 +1,73 @@
>> +/**
>> + * Licensed to the Apache Software Foundation (ASF) under one or more
>> + * contributor license agreements.  See the NOTICE file distributed with
>> + * this work for additional information regarding copyright ownership.
>> + * The ASF licenses this file to You under the Apache License, 
>> Version 2.0
>> + * (the "License"); you may not use this file except in compliance with
>> + * the License.  You may obtain a copy of the License at
>> + *
>> + *     http://www.apache.org/licenses/LICENSE-2.0
>> + *
>> + * Unless required by applicable law or agreed to in writing, software
>> + * distributed under the License is distributed on an "AS IS" BASIS,
>> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
>> implied.
>> + * See the License for the specific language governing permissions and
>> + * limitations under the License.
>> + */
>> +package org.apache.geronimo.webservices;
>> +
>> +import org.apache.geronimo.gbean.GBeanInfo;
>> +import org.apache.geronimo.gbean.GBeanInfoBuilder;
>> +import org.apache.geronimo.gbean.GBeanLifecycle;
>> +import org.apache.geronimo.j2ee.j2eeobjectnames.NameFactory;
>> +
>> +public class SystemPropertyGBean implements GBeanLifecycle {
>> +
>> +    private String propertyName;
>> +    private String propertyValue;
>> +    +    public SystemPropertyGBean(String propertyName, String 
>> propertyValue) {
>> +        if (propertyName == null || propertyValue == null) {
>> +            throw new IllegalArgumentException("Property name or 
>> value is null");
>> +        }
>> +        +        this.propertyName = propertyName;
>> +        this.propertyValue = propertyValue;
>> +    }
>> +
>> +    public void doStart() throws Exception {
>> +        setProperty(this.propertyName, this.propertyValue);          
>> +    }
>> +
>> +    private void setProperty(String propertyName, String value) {
>> +        String propValue = System.getProperty(propertyName);
>> +        // set only if the property is not set
>> +        if (propValue == null) {
>> +            System.setProperty(propertyName, value);
>> +        }        +    }
>> +    +    public void doStop() throws Exception {             +    }
>> +
>> +    public void doFail() {
>> +    }
>> +
>> +    public static final GBeanInfo GBEAN_INFO;
>> +
>> +    static {
>> +        GBeanInfoBuilder infoFactory = 
>> GBeanInfoBuilder.createStatic(SystemPropertyGBean.class, 
>> SystemPropertyGBean.class, NameFactory.GERONIMO_SERVICE);
>> +                +        infoFactory.addAttribute("propertyName", 
>> String.class, true, true);
>> +        infoFactory.addAttribute("propertyValue", String.class, true, 
>> true);
>> +        +        infoFactory.setConstructor(new String[] 
>> {"propertyName", "propertyValue"});
>> +        +        GBEAN_INFO = infoFactory.getBeanInfo();
>> +    }
>> +
>> +    public static GBeanInfo getGBeanInfo() {
>> +        return GBEAN_INFO;
>> +    }
>> +
>> +}
>>
>> Propchange: 
>> geronimo/server/trunk/modules/geronimo-webservices/src/main/java/org/apache/geronimo/webservices/SystemPropertyGBean.java

>>
>> ------------------------------------------------------------------------------ 
>>
>>     svn:eol-style = native
>>
>>
>>
>>

Mime
View raw message