geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevan Miller <kevan.mil...@gmail.com>
Subject Re: [jira] Resolved: (GERONIMO-3017) Web Apps (WAR files) that directly contain JPA entities cannot be deployed
Date Tue, 17 Apr 2007 10:44:15 GMT

On Apr 17, 2007, at 2:19 AM, Jacek Laskowski wrote:

> On 4/16/07, Kevan Miller (JIRA) <jira@apache.org> wrote:
>>
>>      [ https://issues.apache.org/jira/browse/GERONIMO-3017? 
>> page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Kevan Miller resolved GERONIMO-3017.
>> ------------------------------------
>>
>>        Resolution: Fixed
>>     Fix Version/s: 2.0-M5
>>
>> Applied patch. Thanks Jay!
>>
>> I didn't do anything with your patch program, since you didn't  
>> click the grant asf license button.
>
> That struck me. How could we apply this patch then? It's our codebase
> now so anybody can modify it now and has not been able before? I think
> we need to revert the change and ask Jay for the license to include
> it. Only afterwards are we allowed to apply the patch, aren't we?
>
> I've seen Jay licensed the code to us so I wonder whether we shouldn't
> re-apply it with the former commit reverted?

Jacek,
There were two parts to that Jira. A code patch and a test program.  
Jay did grant the ASF license to his 'patch'. He didn't grant the ASF  
license to his test program.

I only applied the patch. I used, but did not apply his test program.  
So, I don't see any issues...

--kevan

Mime
View raw message