geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Dillon <ja...@planet57.com>
Subject Re: svn commit: r520610 - /geronimo/server/trunk/modules/geronimo-axis2/pom.xml
Date Wed, 21 Mar 2007 00:55:20 GMT
I just don't want to see more hacks of this nature make it into the  
codebase... as they tend to have a nasty habit of staying there.

Seems like the ws effort also is prone to taking shortcuts to get  
things done quickly rather than properly... its not really that much  
extra effort to resolve issues without gross hacks like tricking  
maven into not compiling/running tests by telling it to use an  
invalid directory name.

I personally would like to see a little more attention to detail and  
less quick to commit changes which break things, which seems to be  
quite common these days.

--jason


On Mar 20, 2007, at 5:46 PM, Jarek Gawor wrote:

> Jason,
>
> I'm sorry but this is a bit silly. It was a hack. A hack is a hack. It
> did its job and Dims or I would have fixed it properly shortly.
>
> Jarek
>
> On 3/20/07, Jason Dillon <jason@planet57.com> wrote:
>> IMO, this is *not* a suitable hack.  I've updated the class to
>> compile and disabled the test.  Though I could have just excluded the
>> src from being compiled too.
>>
>> In the future... please don't add any _hacks_ like this.
>>
>> And... your indent is still off.  I would really appreciate it if you
>> could fix this for future commits.
>>
>> Thanks,
>>
>> --jason
>>
>>
>> On Mar 20, 2007, at 2:41 PM, gawor@apache.org wrote:
>>
>> > Author: gawor
>> > Date: Tue Mar 20 14:41:51 2007
>> > New Revision: 520610
>> >
>> > URL: http://svn.apache.org/viewvc?view=rev&rev=520610
>> > Log:
>> > a hack to disable axis2 tests
>> >
>> > Modified:
>> >     geronimo/server/trunk/modules/geronimo-axis2/pom.xml
>> >
>> > Modified: geronimo/server/trunk/modules/geronimo-axis2/pom.xml
>> > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/
>> > geronimo-axis2/pom.xml?view=diff&rev=520610&r1=520609&r2=520610
>> >  
>> ===================================================================== 
>> =
>> > ========
>> > --- geronimo/server/trunk/modules/geronimo-axis2/pom.xml (original)
>> > +++ geronimo/server/trunk/modules/geronimo-axis2/pom.xml Tue Mar 20
>> > 14:41:51 2007
>> > @@ -185,6 +185,9 @@
>> >      </dependencies>
>> >
>> >      <build>
>> > +
>> > +      <testSourceDirectory>src/test/javaa</testSourceDirectory>
>> > +
>> >          <plugins>
>> >              <plugin>
>> >                  <groupId>org.codehaus.mojo</groupId>
>> >
>> >
>>
>>


Mime
View raw message