Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Received-SPF: pass (herse.apache.org: domain of jgawor@gmail.com designates
 66.249.92.174 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=KxAI/MtTnpLhng2fgtoOvfsnRS9FZKqMtox2YJmWKVHI8EmXIPnLCCsj3jISXl1so2PNOecf+/BeYsPhSwlI+lV2Roylgx3wEidAygX5DjUuuTHZp5OGYz/y/i1MS85VWyABpQy59LXerLlL/xTrvT7Dh+L2c1ppqaAoRMr6yys=
Message-ID: <5eb405c70702112014j71f4526chb76f823e99b264d6@mail.gmail.com>
Date: Sun, 11 Feb 2007 23:14:27 -0500
From: "Jarek Gawor" <jgawor@gmail.com>
To: dev@geronimo.apache.org
Subject: Re: EjbModuleBuilder passing in null arguments to buildEnvironemnt
In-Reply-To: <7DC926FC-7641-44DE-83B4-0AB736CE57EF@iq80.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <45CCD93B.1080004@earthlink.net>
	 <DC24E160-1769-4A54-B44F-BD71D7C9EDBF@gmail.com>
	 <35A5AEF9-4FF4-49F7-9C8F-AFC2DACA813A@gmail.com>
	 <7DC926FC-7641-44DE-83B4-0AB736CE57EF@iq80.com>

Created https://issues.apache.org/jira/browse/GERONIMO-2821 with a
patch that should fix this issue.

Jarek

On 2/11/07, Dain Sundstrom <dain@iq80.com> wrote:
> Moving to dev@geronimo from tck list as this is non tck related.
>
> On Feb 11, 2007, at 10:26 AM, Sachin Patel wrote:
>
> > EjbModuleBuilder is passing in null for both the spec and G plans.
> > David what is the intent here?
> >
> > if (ejbModule.getEjbJar().getAssemblyDescriptor() != null) {
> >       namingBuilder.buildEnvironment(null, null, environment);
> > }
>
> I wrote this code.
>
> We agreed on the dev list that all naming builders would be hard
> coded to always add their environment.  This is because we must build
> the environment before we have a class loader and we do not know what
> refs a bean has until we have a class loader (due to the need for
> annotation scanning).
>
> Since they are hard coded to always add their environiment, there
> should be no inspection of the spec or vendor plans and null is ok.
> In the case of EjbModuleBuilder we have not have the XMLBeans trees
> at that point in the build so we can not pass in valid args anyway.
>
> As for your specific problem:
>
> Caused by: java.lang.NullPointerException
>          at
> org.apache.geronimo.naming.deployment.SwitchingServiceRefBuilder.buildEn
> vironment(SwitchingServiceRefBuilder.java:76)
>          at
> org.apache.geronimo.naming.deployment.SwitchingServiceRefBuilder$
> $FastClassByCGLIB$$c7ee5732.invoke(<generated>)
>
> The SwitchingServiceRefBuilder is inspecting the XMLBeans tree
> looking for jaxrpc and jaxws references which is not allowed.  That
> builder should be hard coded to always add the dependencies.
>
> -dain
>
>