geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevan Miller <kevan.mil...@gmail.com>
Subject Re: [jira] Commented: (GERONIMO-2800) Connector Lazy Activation leaks managed connections
Date Sat, 10 Feb 2007 17:51:47 GMT

On Feb 5, 2007, at 10:47 PM, Dain Sundstrom (JIRA) wrote:

>
>     [ https://issues.apache.org/jira/browse/GERONIMO-2800? 
> page=com.atlassian.jira.plugin.system.issuetabpanels:comment- 
> tabpanel#action_12470441 ]
>
> Dain Sundstrom commented on GERONIMO-2800:
> ------------------------------------------
>
> I think I have fixed this problem in revision 503969.  When  
> connections are closed or destroyed do not reassociate the  
> connection again or throw an exception.  Instead simply invoke the  
> handle and let the handle throw the exception.
>
> Please verify.

Dain,
Thanks for fixing this. I'd like to point out some things that I  
think could have been done better...

When I pinned down the cause of this problem on the lazy connection  
support, I had no motivation to actually try and fix the lazy  
connection support. It appeared to be an optional feature and few, if  
anyone, understood why it had been added to Connector. My bad for not  
asking for information on your initial commit. It would be really  
useful to provide some of this information in the form of dev list  
discussion, code comments,  and/or svn commit messages. I'll note  
that even with this fix, we still don't have a context for why lazy  
connections are needed (any info I have was obtained via IRC).

IIUC, you did not want to use the ConnectionTracking mechanism for  
OpenEJB 3 connectors. So, you created a proxy-based approach,  
instead. So, we are dependent on this feature for OpenEJB support.

--kevan

Mime
View raw message