geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dain Sundstrom <>
Subject Re: Persistence deployer bugs?
Date Thu, 08 Feb 2007 01:41:20 GMT
On Feb 7, 2007, at 4:55 PM, David Jencks wrote:

> On Feb 7, 2007, at 3:56 PM, Dain Sundstrom wrote:
>> On Feb 7, 2007, at 2:10 PM, David Jencks wrote:
>>> On Feb 7, 2007, at 1:34 PM, Dain Sundstrom wrote:
>>>> I'm confused by the way persistence units are being handled.   
>>>> First it seem that I must declare my persistence units in the  
>>>> geronimo-*.xml files and that persistence.xml files in the class  
>>>> path are not discovered.  Is that true, and if so is anyone  
>>>> working on implementing this?
>>> that's true, I thought david blevins said he had some code that  
>>> found all the persistence.xmls but I haven't located that code.
>>         ResourceFinder finder = new ResourceFinder("",  
>> classLoader, urls);
>>         List<URL> persistenceUrls = finder.findAll("META-INF/ 
>> persistence.xml");
>>>> Second, it doesn't appear the the persistence unit gbean names  
>>>> are not very unique.  Specifically, I'm seeing names like  
>>>> "geronimo:J2EEServer=geronimo,name=cmp, j2eeType=GBean".  This  
>>>> means that you can only have one persistence unit in the entire  
>>>> server with a specific name.  I believe that persistence units  
>>>> are supposed to be application scoped.  This specific bug will  
>>>> prevent two ejb modules that use CMP to be running in the server  
>>>> at the same time. Again, anyone aware of this, and is there  
>>>> anyone working on it.
>>> That looks like a bug, probably I called the wrong buildChildName  
>>> method or supplied the wrong parent name.
>>> please go ahead and fix these if possible.
>> I don't really have the time to fix these, but if someone else  
>> wants to that would be great.  I don't even know where this code  
>> lives.
> PersistenceUnitBuilder
> I can probably fix these tomorrow

If you have time, it would be nice if the datasource names use the  
same format as the Openejb2 "cmp-conection-factor" "resource-link"   
Then in the 2 to 3 converter I can just copy the value over to the  
jtaDataSource element of the persistence.xml.  Otherwise, do you know  
how to coerce the old resource-link name to what the jtaDataSource  
element expects?



View raw message