geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dain Sundstrom <d...@iq80.com>
Subject Re: svn commit: r499201 - in /geronimo/server/trunk/modules/geronimo-kernel/src: main/java/org/apache/geronimo/gbean/ main/java/org/apache/geronimo/gbean/runtime/ test/java/org/apache/geronimo/gbean/
Date Fri, 02 Feb 2007 06:09:33 GMT
When that code used to be in the PersistenceUnitReference class when  
you would deploy an application with a persistence unit reference and  
you looked up that refernce... you would get an exception saying that  
there is no operation named getEntityManagerFactory of that bean.

You can most likely reproduce this by creating a standard gbean like  
this:

public class SomeGBean {
    private String foo;
    public String getFoo() { return foo; }
    public void setFoo(String foo { this.foo = foo; }
}

then call this

kernel.setAttribute(name, "foo", "bar");
assertEquals("bar", kernel.getAttribute(name, "foo"));
assertEquals("bar", kernel.invoke(name, "getFoo"));

I'd guess that the second call will fail with your patch, because the  
the getter and setters exposed as operations (just as an attribute).   
This is just my guess.

-dain

On Feb 1, 2007, at 8:14 PM, anita kulshreshtha wrote:

> Dain,
>    Could you please provide some information on how to reproduce this
> failure?
>
> Thanks
> Anita
>
> --- Dain Sundstrom <dain@iq80.com> wrote:
>
>> I think this has broken some stuff.  This piece of code in
>> PersistenceUnitReference is no longer working:
>>
>>          entityManagerFactory = kernel.invoke(target,
>> "getEntityManagerFactory");
>>
>> I'll try to code around the problem for this instance, but you may
>> want to roll back this commit.
>>
>> -dain
>>
>> On Jan 23, 2007, at 4:55 PM, hogstrom@apache.org wrote:
>>
>>> Author: hogstrom
>>> Date: Tue Jan 23 16:55:35 2007
>>> New Revision: 499201
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=499201
>>> Log:
>>> GERONIMO-2607 : Deprecated old addOperation methods, added private
>>> addOperation methods
>>>                 updated GBeanInfoTest
>>>                 Modified GBeanOperation, this class is not
>> serialized
>>>
>>> Modified:
>>>
>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>> apache/geronimo/gbean/GBeanInfoBuilder.java
>>>
>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>> apache/geronimo/gbean/GOperationInfo.java
>>>
>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>> apache/geronimo/gbean/runtime/GBeanOperation.java
>>>
>> geronimo/server/trunk/modules/geronimo-kernel/src/test/java/org/
>>> apache/geronimo/gbean/GBeanInfoTest.java
>>>
>>> Modified: geronimo/server/trunk/modules/geronimo-kernel/src/main/
>>> java/org/apache/geronimo/gbean/GBeanInfoBuilder.java
>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/
>>> geronimo-kernel/src/main/java/org/apache/geronimo/gbean/
>>> GBeanInfoBuilder.java?view=diff&rev=499201&r1=499200&r2=499201
>>>
>>
> ======================================================================
>>
>>> ========
>>> ---
>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>> apache/geronimo/gbean/GBeanInfoBuilder.java (original)
>>> +++
>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>> apache/geronimo/gbean/GBeanInfoBuilder.java Tue Jan 23 16:55:35
>> 2007
>>> @@ -403,23 +403,23 @@
>>>
>>>      /**
>>>       * @deprecated
>>> -     */
>>> +     */
>>>      public void addOperation(String name) {
>>> -        addOperation(new GOperationInfo(name, NO_ARGS, ""));
>>> +        //addOperation(new GOperationInfo(name, NO_ARGS, ""));
>>>      }
>>>
>>>      /**
>>>       * @deprecated
>>>       */
>>>      public void addOperation(String name, Class[] paramTypes) {
>>> -        addOperation(new GOperationInfo(name, paramTypes, ""));
>>> +        //addOperation(new GOperationInfo(name, paramTypes, ""));
>>>      }
>>>
>>> -    public void addOperation(String name, String returnType) {
>>> +    private void addOperation(String name, String returnType) {
>>>          addOperation(new GOperationInfo(name, NO_ARGS,
>> returnType));
>>>      }
>>>
>>> -    public void addOperation(String name, Class[] paramTypes,
>>> String returnType) {
>>> +    private void addOperation(String name, Class[] paramTypes,
>>> String returnType) {
>>>          addOperation(new GOperationInfo(name, paramTypes,
>>> returnType));
>>>      }
>>>
>>>
>>> Modified: geronimo/server/trunk/modules/geronimo-kernel/src/main/
>>> java/org/apache/geronimo/gbean/GOperationInfo.java
>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/
>>> geronimo-kernel/src/main/java/org/apache/geronimo/gbean/
>>> GOperationInfo.java?view=diff&rev=499201&r1=499200&r2=499201
>>>
>>
> ======================================================================
>>
>>> ========
>>> ---
>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>> apache/geronimo/gbean/GOperationInfo.java (original)
>>> +++
>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>> apache/geronimo/gbean/GOperationInfo.java Tue Jan 23 16:55:35 2007
>>> @@ -38,7 +38,7 @@
>>>      /**
>>>       * The return type of this method.
>>>       */
>>> -    private final String type;
>>> +    private final String returnType;
>>>
>>>      /**
>>>       * Parameters of this method.
>>> @@ -54,9 +54,9 @@
>>>          this(name, name, Collections.EMPTY_LIST, type);
>>>      }
>>>
>>> -    public GOperationInfo(String name, Class[] paramTypes, String
>>
>>> type) {
>>> +    public GOperationInfo(String name, Class[] paramTypes, String
>>
>>> returnType) {
>>>          this.name = this.methodName = name;
>>> -        this.type = type;
>>> +        this.returnType = returnType;
>>>          String[] args = new String[paramTypes.length];
>>>          for (int i = 0; i < args.length; i++) {
>>>              args[i] = paramTypes[i].getName();
>>> @@ -64,17 +64,17 @@
>>>          this.parameters = Collections.unmodifiableList
>>> (Arrays.asList(args));
>>>      }
>>>
>>> -    public GOperationInfo(String name, String[] paramTypes, String
>>
>>> type) {
>>> -        this(name, name, Arrays.asList(paramTypes), type);
>>> +    public GOperationInfo(String name, String[] paramTypes, String
>>
>>> returnType) {
>>> +        this(name, name, Arrays.asList(paramTypes), returnType);
>>>      }
>>>
>>> -    public GOperationInfo(String name, List parameters, String
>>> type) {
>>> -        this(name, name, parameters, type);
>>> +    public GOperationInfo(String name, List parameters, String
>>> returnType) {
>>> +        this(name, name, parameters, returnType);
>>>      }
>>>
>>> -    public GOperationInfo(String name, String methodName, List
>>> parameters, String type) {
>>> +    public GOperationInfo(String name, String methodName, List
>>> parameters, String returnType) {
>>>          this.name = name;
>>> -        this.type = type;
>>> +        this.returnType = returnType;
>>>          this.methodName = methodName;
>>>          this.parameters = Collections.unmodifiableList(new
>>> ArrayList(parameters));
>>>      }
>>> @@ -84,7 +84,7 @@
>>>      }
>>>
>>>      public String getReturnType() {
>>> -        return type;
>>> +        return returnType;
>>>      }
>>>
>>>      public String getMethodName() {
>>> @@ -96,6 +96,6 @@
>>>      }
>>>
>>>      public String toString() {
>>> -        return "[GOperationInfo: name=" + name + " parameters=" +
>>
>>> parameters + " type =" + type + "]";
>>> +        return "[GOperationInfo: name=" + name + " parameters=" +
>>
>>> parameters + " returnType =" + returnType + "]";
>>>      }
>>>  }
>>>
>>> Modified: geronimo/server/trunk/modules/geronimo-kernel/src/main/
>>> java/org/apache/geronimo/gbean/runtime/GBeanOperation.java
>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/
>>> geronimo-kernel/src/main/java/org/apache/geronimo/gbean/runtime/
>>> GBeanOperation.java?view=diff&rev=499201&r1=499200&r2=499201
>>>
>>
> ======================================================================
>>
>>> ========
>>> ---
>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>> apache/geronimo/gbean/runtime/GBeanOperation.java (original)
>>> +++
>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>> apache/geronimo/gbean/runtime/GBeanOperation.java Tue Jan 23
>>> 16:55:35 2007
>>
> === message truncated ===
>
>
>
>
> ______________________________________________________________________ 
> ______________
> Sucker-punch spam with award-winning protection.
> Try the free Yahoo! Mail Beta.
> http://advision.webevents.yahoo.com/mailbeta/features_spam.html


Mime
View raw message