From dev-return-43773-apmail-geronimo-dev-archive=geronimo.apache.org@geronimo.apache.org Wed Jan 03 14:09:51 2007 Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 17975 invoked from network); 3 Jan 2007 14:09:51 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Jan 2007 14:09:51 -0000 Received: (qmail 83698 invoked by uid 500); 3 Jan 2007 14:09:56 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 83395 invoked by uid 500); 3 Jan 2007 14:09:55 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 83384 invoked by uid 99); 3 Jan 2007 14:09:55 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jan 2007 06:09:55 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jan 2007 06:09:47 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id B78D8714311 for ; Wed, 3 Jan 2007 06:09:27 -0800 (PST) Message-ID: <23746308.1167833367748.JavaMail.jira@brutus> Date: Wed, 3 Jan 2007 06:09:27 -0800 (PST) From: "Vamsavardhana Reddy (JIRA)" To: dev@geronimo.apache.org Subject: [jira] Commented: (GERONIMO-438) Deployer.deploy arguments inconsistent In-Reply-To: <790761385.1099624292020.JavaMail.apache@nagoya> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/GERONIMO-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12461959 ] Vamsavardhana Reddy commented on GERONIMO-438: ---------------------------------------------- Sachin, can you check if reordering the moduleFile and planFile arguments in the 3rd method has any impact on the DEVTOOLS? If you can identify any calls to this 3rd deploy method we can change those accordingly and conclude this JIRA. > Deployer.deploy arguments inconsistent > -------------------------------------- > > Key: GERONIMO-438 > URL: https://issues.apache.org/jira/browse/GERONIMO-438 > Project: Geronimo > Issue Type: Bug > Components: deployment > Affects Versions: 1.0-M2 > Reporter: Aaron Mulder > Fix For: Wish List > > Attachments: g-438-11x-option2.patch, g-438-option1.patch, g-438-option2.patch > > > One deploy method starts with the arguments: > File module, File plan > Another overloaded deploy method starts with the arguments: > File plan, File module > These should not be reversed, but we need to carefully hunt down usages since the types alone won't cause the usages to be flagged if one is switched. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira