geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shiva Kumar H R (JIRA)" <j...@apache.org>
Subject [jira] Commented: (GERONIMODEVTOOLS-123) Complete Editor Support for specifying EJB References, EJB Local References, Resource References & Resource Environment References in geronimo-web.xml
Date Wed, 03 Jan 2007 14:05:27 GMT

    [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12461958
] 

Shiva Kumar H R commented on GERONIMODEVTOOLS-123:
--------------------------------------------------

Sachin,
Thanks for having started to look into this. Of late I was becoming skeptical as to whether
this work would be accepted or not considering that the focus is now on Annotations. Bit relaxed
now looking at some comments in this JIRA :)

1) Reason for setting Wizard title at lines 187 & 198 in the patch:
Currently Wizards have their title set as "Add ..." irrespective of whether Add button is
clicked or Edit button is clicked. The changes made in plugins/org.apache.geronimo.st.ui/src/org/apache/geronimo/st/ui/sections/AbstractTableSection.java
fix this problem. Please suggest if there is a better place to achieve this.

2) Group title as instruction:
Yes I have changed this. Group title is now a short label and the instruction is put inside
the group above the buttons as suggested. Thanks for pointing out this.

I am currently working on enhancing the wizards for specifying "Security Configurations",
"GBeans" and "Web Service References". The work is almost complete with some small refinements
pending. Will submit a consolidated patch by tomorrow. 

3) Name of the second column being too long in some of the sections:
I agree especially in "EJB References", "Resource References" & "Resource Environment
References" section. Will think of better names. Between do you suggest any alternative names?

> Complete Editor Support for specifying EJB References, EJB Local References, Resource
References & Resource Environment References in geronimo-web.xml
> ------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: GERONIMODEVTOOLS-123
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-123
>             Project: Geronimo-Devtools
>          Issue Type: Improvement
>          Components: eclipse-plugin
>    Affects Versions: 1.x
>            Reporter: Shiva Kumar H R
>         Assigned To: Sachin Patel
>             Fix For: 1.x
>
>         Attachments: 1a.gif, 1b.gif, 1c.gif, 1d.gif, 1e.gif, 2a.gif, 2b.gif, 3a.gif,
3b.gif, 4a.gif, 4b.gif, GERONIMODEVTOOLS-118-120-122-123-124-consolidated.patch
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message