Return-Path: 
 <dev-return-42998-apmail-geronimo-dev-archive=geronimo.apache.org@geronimo.apache.org>
Delivered-To: apmail-geronimo-dev-archive@www.apache.org
Received: (qmail 41319 invoked from network); 13 Dec 2006 00:11:49 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 13 Dec 2006 00:11:49 -0000
Received: (qmail 51622 invoked by uid 500); 13 Dec 2006 00:11:53 -0000
Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org
Received: (qmail 51592 invoked by uid 500); 13 Dec 2006 00:11:53 -0000
Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@geronimo.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@geronimo.apache.org>
List-Post: <mailto:dev@geronimo.apache.org>
Reply-To: dev@geronimo.apache.org
List-Id: <dev.geronimo.apache.org>
Delivered-To: mailing list dev@geronimo.apache.org
Received: (qmail 51580 invoked by uid 99); 13 Dec 2006 00:11:53 -0000
Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Dec 2006 16:11:53 -0800
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Dec 2006 16:11:43 -0800
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 3B8537140D2
	for <dev@geronimo.apache.org>; Tue, 12 Dec 2006 16:11:23 -0800 (PST)
Message-ID: <33063704.1165968683241.JavaMail.jira@brutus>
Date: Tue, 12 Dec 2006 16:11:23 -0800 (PST)
From: "David Jencks (JIRA)" <jira@apache.org>
To: dev@geronimo.apache.org
Subject: [jira] Commented: (GERONIMO-2653) Inconsistencies between
 jetty6-builder and tomcat6-builder plan.xml files
In-Reply-To: <15377144.1165960760965.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org

    [ http://issues.apache.org/jira/browse/GERONIMO-2653?page=comments#action_12457958 ] 
            
David Jencks commented on GERONIMO-2653:
----------------------------------------

Please give a little more context in the future.... I think the plan extracts are from defaultEnvironment attributes??  

IMO the tomcat6-builder defaultEnvironment should not need to include j2ee-server as long as tomcat6 depends on it.

The tomcat6 deployer shold include the CXFBuilder pattern and the UnavailableWebServiceBuilder should be removed and WebServiceBuilder should be renamed Axis1Builder.

I recently added some capability for multiple ws builders to coexist with the expectation that each builder would only deploy stuff it recognizes.  This should allow us to be able to support jaxrpc using axis1 and jaxws using cxf/axis2 at the same time.  I haven't tested this.   I'm working on a simple cxf integration test which I hope to commit soon.... maybe we can expand it to a better test for this stuff too.


> Inconsistencies between jetty6-builder and tomcat6-builder plan.xml files
> -------------------------------------------------------------------------
>
>                 Key: GERONIMO-2653
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2653
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 2.0
>            Reporter: Jarek Gawor
>
> 1) One of the plans has an extra dependency on the j2ee-server module while the other does not (enough though both tomcat6/pom.xml and jetty6/pom.xml have dependency on j2ee-server module):
> tomcat6-deployer/src/plan/plan.xml contains:
>                 <dependencies>
>                     <dependency>
>                         <groupId>${pom.groupId}</groupId>
>                         <artifactId>j2ee-server</artifactId>
>                         <type>car</type>
>                     </dependency>
>                     <dependency>
>                         <groupId>${pom.groupId}</groupId>
>                         <artifactId>tomcat6</artifactId>
>                         <type>car</type>
>                     </dependency>
>                 </dependencies>           
> while jetty6-deployer/src/plan/plan.xml contains:
>                 <dependencies>
>                     <dependency>
>                         <groupId>${pom.groupId}</groupId>
>                         <artifactId>jetty6</artifactId>
>                         <type>car</type>
>                     </dependency>
>                 </dependencies>
> 2) Also, jetty6-deployer specifies CXFBuilder: 
>         <references name="WebServiceBuilder">
>             <pattern>
>                 <name>CXFBuilder</name>
>             </pattern>
>             <pattern>
>                 <name>WebServiceBuilder</name>
>             </pattern>
>             <pattern>
>                 <name>UnavailableWebServiceBuilder</name>
>             </pattern>
>         </references>
> while tomcat6-deployer does not:
>         <references name="WebServiceBuilder">
>             <pattern>
>                 <name>WebServiceBuilder</name>
>             </pattern>
>             <pattern>
>                 <name>UnavailableWebServiceBuilder</name>
>             </pattern>
>         </references>
> It seems to me like these things should be consistent (unless of course there is a good reason for it). 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira